Bug 192967 - NetworkProcess should initialize its default NetworkSession with parameters from the UIProcess
Summary: NetworkProcess should initialize its default NetworkSession with parameters f...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-20 18:15 PST by Alex Christensen
Modified: 2019-01-03 08:52 PST (History)
2 users (show)

See Also:


Attachments
Patch (14.22 KB, patch)
2018-12-20 18:15 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (8.36 KB, patch)
2018-12-21 11:40 PST, Alex Christensen
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-12-20 18:15:04 PST
NetworkProcess should initialize its default NetworkSession with parameters from the UIProcess
Comment 1 Alex Christensen 2018-12-20 18:15:16 PST
Created attachment 357912 [details]
Patch
Comment 2 Alex Christensen 2018-12-20 18:16:14 PST
Comment on attachment 357912 [details]
Patch

This first patch isn't quite right, but it's headed in the right direction.  For example, the WebKit.WKHTTPCookieStore API test asserts.
Comment 3 Alex Christensen 2018-12-21 11:40:29 PST
Created attachment 357961 [details]
Patch
Comment 4 Brent Fulgham 2019-01-03 08:49:33 PST
Comment on attachment 357961 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357961&action=review

Looks good to me.

> Source/WebKit/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=192967

Radar?

> Source/WebKit/ChangeLog:9
> +        More will be moved in the near future, like indexedDatabaseDirectory.

Good!
Comment 5 Alex Christensen 2019-01-03 08:52:41 PST
http://trac.webkit.org/r239592
The auto-generated radar will be sufficient.  This isn't an important change, and it should have no change in behavior.  It's just leading up to some big changes.