Bug 192963 – REGRESSION(r?): Web Inspector: Popovers have inset shadows

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Created attachment 357905 [details]
[Image] Bug

This doesn't seem intentional.

[Radar WebKit Bug Importer]

<rdar://problem/46888679>

[Devin Rousso]

Created attachment 362664 [details]
Patch

[Devin Rousso]

Created attachment 362665 [details]
[Image] Before Patch is applied

[Devin Rousso]

Created attachment 362666 [details]
[Image] After Patch is applied

[Nikita Vasilyev]

Do you know why this broke?

[Joseph Pecoraro]

Comment on attachment 362664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362664&action=review

> Source/WebInspectorUI/UserInterface/Views/Popover.css:36
>      --popover-shadow-color: hsla(0, 0%, 0%, 0.5);

Can we reduce the padding now that the popover feels a little larger than it was before? Each of the `padding` declarations below could drop a pixel or two.

[Joseph Pecoraro]

Comment on attachment 362664 [details]
Patch

The  macOS system blue seems much larger. For an example of a popover right click the URL bar and select "Settings for this website...". That shadow seems much larger and clearer than this one.

[Joseph Pecoraro]

> The  macOS system blue

system *popover blur*

[Matt Baker]

I’d really like to know what change caused the regression in the first place. I feel like this happened relatively recently.

[Devin Rousso]

(In reply to Nikita Vasilyev from comment #5)
> Do you know why this broke?
(In reply to Matt Baker from comment #9)
> I’d really like to know what change caused the regression in the first place. I feel like this happened relatively recently.
From what I could find, this code has existed since before Web Inspector was added to open source.

[Devin Rousso]

Comment on attachment 362664 [details]
Patch

(In reply to Joseph Pecoraro from comment #7)
> The  macOS system popover blur seems much larger. For an example of a popover right click the URL bar and select "Settings for this website...". That shadow seems much larger and clearer than this one.

View in context: https://bugs.webkit.org/attachment.cgi?id=362664&action=review

>> Source/WebInspectorUI/UserInterface/Views/Popover.css:36
>>      --popover-shadow-color: hsla(0, 0%, 0%, 0.5);
> 
> Can we reduce the padding now that the popover feels a little larger than it was before? Each of the `padding` declarations below could drop a pixel or two.

If we want to make the popover match (or be closer to) the system blur, we'd actually need to increase the padding, as otherwise the blur will get cut off by the bounds of the <canvas> itself.

[Blaze Burg]

Comment on attachment 362664 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 362664 [details]
Patch

Clearing flags on attachment: 362664

Committed r241981: <https://trac.webkit.org/changeset/241981>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.