Bug 192957 - [iOS] Some layout tests are failing after r239441
Summary: [iOS] Some layout tests are failing after r239441
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-20 14:46 PST by Wenson Hsieh
Modified: 2018-12-20 17:32 PST (History)
9 users (show)

See Also:


Attachments
Patch (3.58 KB, patch)
2018-12-20 16:13 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-12-20 14:46:43 PST
SSIA
Comment 1 Wenson Hsieh 2018-12-20 15:00:19 PST
It looks like these are the relevant tests:

• fast/events/ios/click-event-while-editing-node.html
• fast/forms/ios/focus-long-textarea.html (this one can just be rebaselined)
• fast/forms/ios/zoom-after-input-tap-wide-input.html (this one can just be rebaselined too)
• fast/events/ios/key-command-italic-dispatches-keydown.html
Comment 2 Wenson Hsieh 2018-12-20 15:40:17 PST
(In reply to Wenson Hsieh from comment #1)
> It looks like these are the relevant tests:
> 
> • fast/events/ios/click-event-while-editing-node.html

This test is actually dependent on buggy behavior (scrolling to the touch location rather than the selection), which was fixed in r239441. This just needs to be tweaked slightly.
Comment 3 Wenson Hsieh 2018-12-20 16:01:26 PST
(In reply to Wenson Hsieh from comment #1)
> It looks like these are the relevant tests:
> …
> • fast/events/ios/key-command-italic-dispatches-keydown.html

It turns out that this test has the same result before and after my change.
Comment 4 Wenson Hsieh 2018-12-20 16:08:10 PST
<rdar://problem/46781759>
Comment 5 Wenson Hsieh 2018-12-20 16:13:49 PST
Created attachment 357894 [details]
Patch
Comment 6 WebKit Commit Bot 2018-12-20 17:32:23 PST
Comment on attachment 357894 [details]
Patch

Clearing flags on attachment: 357894

Committed r239482: <https://trac.webkit.org/changeset/239482>
Comment 7 WebKit Commit Bot 2018-12-20 17:32:24 PST
All reviewed patches have been landed.  Closing bug.