Bug 192953 - Ensure new styles are served on webkit.org
Summary: Ensure new styles are served on webkit.org
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Davis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-20 13:48 PST by Jon Davis
Modified: 2018-12-20 15:20 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.90 KB, patch)
2018-12-20 13:50 PST, Jon Davis
no flags Details | Formatted Diff | Diff
Patch (3.94 KB, patch)
2018-12-20 13:54 PST, Jon Davis
drousso: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Davis 2018-12-20 13:48:30 PST
Update the stylesheet date to invalidate cache. Also re-remove the vector tab icon from the site.
Comment 1 Jon Davis 2018-12-20 13:50:08 PST
Created attachment 357863 [details]
Patch
Comment 2 Devin Rousso 2018-12-20 13:51:45 PST
Comment on attachment 357863 [details]
Patch

rs=me, maybe add a ChangeLog comment as to why tabicon.svg was removed
Comment 3 Jon Davis 2018-12-20 13:54:28 PST
Created attachment 357864 [details]
Patch
Comment 4 Devin Rousso 2018-12-20 13:55:34 PST
Comment on attachment 357864 [details]
Patch

rs=me :)
Comment 5 WebKit Commit Bot 2018-12-20 13:58:19 PST
Comment on attachment 357864 [details]
Patch

Rejecting attachment 357864 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 357864, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

No handlers could be found for logger "webkitpy.common.system.autoinstall"
Traceback (most recent call last):
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 44, in <module>
    from webkitpy.tool.main import WebKitPatch
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/main.py", line 41, in <module>
    from webkitpy.common.net.statusserver import StatusServer
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/net/statusserver.py", line 33, in <module>
    from webkitpy.common.net.bugzilla.attachment import Attachment
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/__init__.py", line 4, in <module>
    from .bugzilla import Bugzilla
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 49, in <module>
    from webkitpy.common.net.credentials import Credentials
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/net/credentials.py", line 40, in <module>
    from webkitpy.thirdparty.autoinstalled import keyring
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 100, in find_module
    self._install_keyring()
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 124, in _install_keyring
    "keyring-7.3.1/keyring")
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 257, in _install
    installer.install(url=url, url_subpath=url_subpath, target_name=target_name)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/system/autoinstall.py", line 517, in install
    raise Exception(message)
Exception: Error auto-installing the keyring package to:
 "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/keyring"
 --> Inner message: Could not download Python modules from URL "None".
 Make sure you are connected to the internet.
 You must be connected to the internet when downloading needed modules for the first time.
 --> Inner message: <urlopen error [SSL: TLSV1_ALERT_PROTOCOL_VERSION] tlsv1 alert protocol version (_ssl.c:590)>

Full output: https://webkit-queues.webkit.org/results/10496780
Comment 6 Joseph Pecoraro 2018-12-20 15:19:09 PST
https://trac.webkit.org/r239468
Comment 7 Radar WebKit Bug Importer 2018-12-20 15:20:32 PST
<rdar://problem/46885304>