Bug 192950 - Implement imagesrcset and imagesizes attributes on link rel=preload
Summary: Implement imagesrcset and imagesizes attributes on link rel=preload
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-20 12:46 PST by Dominic Farolino
Modified: 2019-04-18 05:42 PDT (History)
12 users (show)

See Also:


Attachments
Patch (190.96 KB, patch)
2019-03-27 08:38 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.59 MB, application/zip)
2019-03-27 10:47 PDT, Build Bot
no flags Details
Patch (192.19 KB, patch)
2019-03-29 09:43 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-highsierra (2.44 MB, application/zip)
2019-03-29 10:55 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.73 MB, application/zip)
2019-03-29 11:10 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-highsierra (2.26 MB, application/zip)
2019-03-29 11:38 PDT, Build Bot
no flags Details
Patch (192.19 KB, patch)
2019-03-29 15:04 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (150.63 KB, patch)
2019-04-18 03:38 PDT, Rob Buis
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.64 MB, application/zip)
2019-04-18 05:42 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Farolino 2018-12-20 12:46:57 PST
It is useful for the UA to be able to preload responsive images. The idea is to allow this with the imagesrcset and imagesizes attributes on <link rel=preload as=image>. Spec PRs and discussions:

 - https://github.com/w3c/preload/issues/120 (Initial discussion)
 - https://github.com/whatwg/html/pull/4048 (HTML Standard PR)
 - https://github.com/w3c/preload/pull/134 (Preload Spec PR (minor))
Comment 1 Rob Buis 2019-03-27 08:38:59 PDT
Created attachment 366072 [details]
Patch
Comment 2 Build Bot 2019-03-27 10:47:43 PDT
Comment on attachment 366072 [details]
Patch

Attachment 366072 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11684853

New failing tests:
imported/w3c/web-platform-tests/preload/link-header-preload-srcset.tentative.html
Comment 3 Build Bot 2019-03-27 10:47:45 PDT
Created attachment 366082 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 4 Rob Buis 2019-03-29 09:43:30 PDT
Created attachment 366276 [details]
Patch
Comment 5 Build Bot 2019-03-29 10:55:09 PDT
Comment on attachment 366276 [details]
Patch

Attachment 366276 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11703692

New failing tests:
imported/w3c/web-platform-tests/preload/link-header-preload-srcset.tentative.html
Comment 6 Build Bot 2019-03-29 10:55:11 PDT
Created attachment 366282 [details]
Archive of layout-test-results from ews100 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 7 Build Bot 2019-03-29 11:10:18 PDT
Comment on attachment 366276 [details]
Patch

Attachment 366276 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11703728

New failing tests:
imported/w3c/web-platform-tests/preload/link-header-preload-srcset.tentative.html
Comment 8 Build Bot 2019-03-29 11:10:20 PDT
Created attachment 366283 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 9 Build Bot 2019-03-29 11:38:48 PDT
Comment on attachment 366276 [details]
Patch

Attachment 366276 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11703770

New failing tests:
imported/w3c/web-platform-tests/preload/link-header-preload-srcset.tentative.html
Comment 10 Build Bot 2019-03-29 11:38:50 PDT
Created attachment 366285 [details]
Archive of layout-test-results from ews112 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 11 Rob Buis 2019-03-29 15:04:31 PDT
Created attachment 366308 [details]
Patch
Comment 12 Rob Buis 2019-04-02 07:52:45 PDT
(In reply to Rob Buis from comment #11)
> Created attachment 366308 [details]
> Patch

Note that the parameter list for loadLink is quite long, it may make sense to consolidate them in a single class, but I think it should be a separate patch.
Comment 13 Rob Buis 2019-04-18 03:38:57 PDT
Created attachment 367724 [details]
Patch
Comment 14 Build Bot 2019-04-18 05:42:28 PDT
Comment on attachment 367724 [details]
Patch

Attachment 367724 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11913509

New failing tests:
imported/w3c/web-platform-tests/preload/link-header-preload-srcset.tentative.html
Comment 15 Build Bot 2019-04-18 05:42:30 PDT
Created attachment 367725 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6