RESOLVED FIXED Bug 192949
[WebAuthN] Import an APDU coder from Chromium 
https://bugs.webkit.org/show_bug.cgi?id=192949
Summary [WebAuthN] Import an APDU coder from Chromium
Jiewen Tan
Reported 2018-12-20 12:42:29 PST
Import an APDU coder from Chromium. APDU is a binary format to frame any U2F requests/responses into binaries. It is equivalent to CBOR in CTAP2.
Attachments
Patch (37.47 KB, patch)
2018-12-20 13:12 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (37.45 KB, patch)
2018-12-20 16:45 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-12-20 12:43:25 PST
<rdar://problem/46879933>
Jiewen Tan
Comment 2 2018-12-20 13:12:02 PST
Created attachment 357855 [details] Patch
EWS Watchlist
Comment 3 2018-12-20 13:17:28 PST
Comment hidden (obsolete)
Jiewen Tan
Comment 4 2018-12-20 16:45:08 PST
Created attachment 357899 [details] Patch
EWS Watchlist
Comment 5 2018-12-20 16:47:38 PST
Attachment 357899 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/webauthn/apdu/ApduResponse.h:64: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/apdu/ApduResponse.h:65: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:68: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:69: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:70: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:71: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:72: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:73: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:75: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:76: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:77: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:78: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:79: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:80: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 14 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 6 2018-12-21 14:23:05 PST
Comment on attachment 357899 [details] Patch Looks good! r=me
Jiewen Tan
Comment 7 2018-12-21 14:41:20 PST
Comment on attachment 357899 [details] Patch Thanks Brent for r+ this patch.
WebKit Commit Bot
Comment 8 2018-12-21 15:07:03 PST
Comment on attachment 357899 [details] Patch Clearing flags on attachment: 357899 Committed r239520: <https://trac.webkit.org/changeset/239520>
WebKit Commit Bot
Comment 9 2018-12-21 15:07:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.