Bug 192949 - [WebAuthN] Import an APDU coder from Chromium
Summary: [WebAuthN] Import an APDU coder from Chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency treegraph
 
Reported: 2018-12-20 12:42 PST by Jiewen Tan
Modified: 2018-12-21 15:07 PST (History)
7 users (show)

See Also:


Attachments
Patch (37.47 KB, patch)
2018-12-20 13:12 PST, Jiewen Tan
no flags Details | Formatted Diff | Diff
Patch (37.45 KB, patch)
2018-12-20 16:45 PST, Jiewen Tan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2018-12-20 12:42:29 PST
Import an APDU coder from Chromium. APDU is a binary format to frame any U2F requests/responses into binaries. It is equivalent to CBOR in CTAP2.
Comment 1 Radar WebKit Bug Importer 2018-12-20 12:43:25 PST
<rdar://problem/46879933>
Comment 2 Jiewen Tan 2018-12-20 13:12:02 PST
Created attachment 357855 [details]
Patch
Comment 3 Build Bot 2018-12-20 13:17:28 PST Comment hidden (obsolete)
Comment 4 Jiewen Tan 2018-12-20 16:45:08 PST
Created attachment 357899 [details]
Patch
Comment 5 Build Bot 2018-12-20 16:47:38 PST
Attachment 357899 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webauthn/apdu/ApduResponse.h:64:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/Modules/webauthn/apdu/ApduResponse.h:65:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:68:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:69:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:70:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:71:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:72:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:73:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:75:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:76:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:77:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:78:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:79:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/Modules/webauthn/apdu/ApduCommand.h:80:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 14 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Brent Fulgham 2018-12-21 14:23:05 PST
Comment on attachment 357899 [details]
Patch

Looks good! r=me
Comment 7 Jiewen Tan 2018-12-21 14:41:20 PST
Comment on attachment 357899 [details]
Patch

Thanks Brent for r+ this patch.
Comment 8 WebKit Commit Bot 2018-12-21 15:07:03 PST
Comment on attachment 357899 [details]
Patch

Clearing flags on attachment: 357899

Committed r239520: <https://trac.webkit.org/changeset/239520>
Comment 9 WebKit Commit Bot 2018-12-21 15:07:05 PST
All reviewed patches have been landed.  Closing bug.