Bug 192948 - Use Optional::hasValue() instead of Optional::has_value()
Summary: Use Optional::hasValue() instead of Optional::has_value()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 192728
Blocks:
  Show dependency treegraph
 
Reported: 2018-12-20 12:40 PST by Chris Dumez
Modified: 2018-12-20 16:45 PST (History)
7 users (show)

See Also:


Attachments
Patch (36.26 KB, patch)
2018-12-20 13:12 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-12-20 12:40:56 PST
Use Optional::hasValue() instead of Optional::has_value().
Comment 1 Chris Dumez 2018-12-20 13:12:01 PST
Created attachment 357854 [details]
Patch
Comment 2 EWS Watchlist 2018-12-20 13:16:15 PST
Attachment 357854 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Optional.h:675:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2018-12-20 16:40:17 PST
Comment on attachment 357854 [details]
Patch

Clearing flags on attachment: 357854

Committed r239477: <https://trac.webkit.org/changeset/239477>
Comment 4 WebKit Commit Bot 2018-12-20 16:40:19 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-12-20 16:45:49 PST
<rdar://problem/46887797>