Bug 192936 – [iOS] Replace "node assistance" terminology in WebKit with "focused element"

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Wenson Hsieh]

We use "node assistance" terminology in many places in WebKit to mean "focused element", but this is strange and confusing to anyone new to this code (e.g. the StartAssistingNode/StopAssistingNode IPC messages). WebPage also has methods like "elementDidFocus" and "elementDidBlur" that currently take Node*, but should really take Element&.

[Wenson Hsieh]

Created attachment 357819 [details]
Patch

[Wenson Hsieh]

Created attachment 357820 [details]
Update a Copyright year

[EWS Watchlist]

Attachment 357820 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/FocusedElementInformation.h:48:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 32 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Wenson Hsieh]

(In reply to Build Bot from comment #3)
> Attachment 357820 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebKit/Shared/FocusedElementInformation.h:48:  enum members
> should use InterCaps with an initial capital letter or initial 'k' for
> C-style enums.  [readability/enum_casing] [4]
> Total errors found: 1 in 32 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

I feel like there should be an exception to this rule for certain acronyms (in this case, URL). I think InputType::URL certainly reads more cleanly than InputType::UniformResourceLocator.

[Tim Horton]

(In reply to Wenson Hsieh from comment #4)
> (In reply to Build Bot from comment #3)
> > Attachment 357820 [details] did not pass style-queue:
> > 
> > 
> > ERROR: Source/WebKit/Shared/FocusedElementInformation.h:48:  enum members
> > should use InterCaps with an initial capital letter or initial 'k' for
> > C-style enums.  [readability/enum_casing] [4]
> > Total errors found: 1 in 32 files
> > 
> > 
> > If any of these errors are false positives, please file a bug against
> > check-webkit-style.
> 
> I feel like there should be an exception to this rule for certain acronyms
> (in this case, URL). I think InputType::URL certainly reads more cleanly
> than InputType::UniformResourceLocator.

Agreed, so ignore it.

[Tim Horton]

Comment on attachment 357820 [details]
Update a Copyright year

rs=me (but strongly agree with the name change)

[WebKit Commit Bot]

Comment on attachment 357820 [details]
Update a Copyright year

Clearing flags on attachment: 357820

Committed r239454: <https://trac.webkit.org/changeset/239454>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46876214>