Bug 192930 - Add dark mode styles to webkit.org
Summary: Add dark mode styles to webkit.org
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Davis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-20 07:36 PST by Jon Davis
Modified: 2018-12-20 10:16 PST (History)
4 users (show)

See Also:


Attachments
Patch (115.33 KB, patch)
2018-12-20 08:36 PST, Jon Davis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Davis 2018-12-20 07:36:51 PST
The webkit.org website should have a great dark mode experience.
Comment 1 Jon Davis 2018-12-20 08:36:57 PST
Created attachment 357813 [details]
Patch
Comment 2 Timothy Hatcher 2018-12-20 10:07:07 PST
Comment on attachment 357813 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357813&action=review

> Websites/webkit.org/wp-content/themes/webkit/functions.php:13
> +//add_action( 'wp_header', 'include_invert_lightness_filter');

Remove or uncomment?

> Websites/webkit.org/wp-content/themes/webkit/header.php:28
> +    <?php include_invert_lightness_filter(); ?>

You add it here.

> Websites/webkit.org/wp-content/themes/webkit/style.css:17
> +    --text-color-coolgray: hsl(240, 2.3%, 56.7%);

Having coolgray in the name is not great. Can this get a more semantic name?

> Websites/webkit.org/wp-content/themes/webkit/style.css:62
> +    --tile-subtle-image-border-shadoww: inset hsla(0, 0%, 0%, 0.1) 0 1px 0 1px;

Typo in the name.

> Websites/webkit.org/wp-content/themes/webkit/style.css:85
> +    --tile-background-color-amber: hsl(48, 100%, 50%);

In the list twice.

> Websites/webkit.org/wp-content/themes/webkit/style.css:87
> +    --gray-tile-text-color: hsl(232.8, 100%, 37.5%);

--title-text-color-gray or just --title-text-color?

> Websites/webkit.org/wp-content/themes/webkit/style.css:95
> +    --figure-mattewhite-background-color: hsl(0, 0%, 100%);

Having mattewhite in the name is not great. Can this get a more semantic name?
Comment 3 WebKit Commit Bot 2018-12-20 10:15:01 PST
Comment on attachment 357813 [details]
Patch

Clearing flags on attachment: 357813

Committed r239448: <https://trac.webkit.org/changeset/239448>
Comment 4 WebKit Commit Bot 2018-12-20 10:15:02 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-12-20 10:16:24 PST
<rdar://problem/46875370>