Bug 192918 - Web Inspector: Audits: don't cache default audits
Summary: Web Inspector: Audits: don't cache default audits
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: WebInspectorAuditTab
Blocks:
  Show dependency treegraph
 
Reported: 2018-12-19 22:52 PST by Devin Rousso
Modified: 2018-12-20 10:15 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.73 KB, patch)
2018-12-19 22:54 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (2.02 KB, patch)
2018-12-20 09:48 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-12-19 22:52:34 PST
If the localization changes between WebInspector sessions, the default audits should use the new localization instead of the old one, which will be cached along with the audit in the IndexedDB.
Comment 1 Devin Rousso 2018-12-19 22:52:44 PST
<rdar://problem/46626543>
Comment 2 Devin Rousso 2018-12-19 22:54:36 PST
Created attachment 357788 [details]
Patch
Comment 3 Brian Burg 2018-12-20 00:06:01 PST
Comment on attachment 357788 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357788&action=review

r=me

> Source/WebInspectorUI/ChangeLog:9
> +        * UserInterface/Controllers/AuditManager.js:

Needs a changelog. For example, explain that by caching you mean using IndexedDB to save the audits. If default audits are not stored in IDB, they will be programmatically recreated every time with UIString labels looked up at runtime using the current locale.
Comment 4 Devin Rousso 2018-12-20 09:48:15 PST
Created attachment 357824 [details]
Patch
Comment 5 WebKit Commit Bot 2018-12-20 10:15:54 PST
Comment on attachment 357824 [details]
Patch

Clearing flags on attachment: 357824

Committed r239449: <https://trac.webkit.org/changeset/239449>
Comment 6 WebKit Commit Bot 2018-12-20 10:15:55 PST
All reviewed patches have been landed.  Closing bug.