WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
192913
UserMedia test should use WKPageNavigationClient
https://bugs.webkit.org/show_bug.cgi?id=192913
Summary
UserMedia test should use WKPageNavigationClient
Michael Catanzaro
Reported
2018-12-19 20:45:43 PST
r239167
"On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early" introduced a deprecation warning: [452/530] Building CXX object Tools/TestWebKitAPI/C...keFiles/TestWebKit.dir/Tests/WebKit/UserMedia.cpp.o ../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp: In member function ‘virtual void TestWebKitAPI::WebKit_OnDeviceChangeCrash_Test::TestBody()’: ../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:139:66: warning: ‘void WKPageSetPageLoaderClient(WKPageRef, const WKPageLoaderClientBase*)’ is deprecated: use WKPageSetPageNavigationClient [-Wdeprecated-declarations] WKPageSetPageLoaderClient(webView2.page(), &loaderClient.base); ^ In file included from DerivedSources/ForwardingHeaders/WebKit/WKPage.h:1, from ../../Source/WebKit/UIProcess/API/C/WebKit2_C.h:53, from DerivedSources/ForwardingHeaders/WebKit/WebKit2_C.h:1, from ../../Tools/TestWebKitAPI/config.h:49, from ../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:20: ../../Source/WebKit/UIProcess/API/C/WKPage.h:228:16: note: declared here WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA)); ^~~~~~~~~~~~~~~~~~~~~~~~~ ../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:139:66: warning: ‘void WKPageSetPageLoaderClient(WKPageRef, const WKPageLoaderClientBase*)’ is deprecated: use WKPageSetPageNavigationClient [-Wdeprecated-declarations] WKPageSetPageLoaderClient(webView2.page(), &loaderClient.base); ^ In file included from DerivedSources/ForwardingHeaders/WebKit/WKPage.h:1, from ../../Source/WebKit/UIProcess/API/C/WebKit2_C.h:53, from DerivedSources/ForwardingHeaders/WebKit/WebKit2_C.h:1, from ../../Tools/TestWebKitAPI/config.h:49, from ../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:20: ../../Source/WebKit/UIProcess/API/C/WKPage.h:228:16: note: declared here WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA)); ^~~~~~~~~~~~~~~~~~~~~~~~~
Attachments
Patch
(2.00 KB, patch)
2018-12-19 21:03 PST
,
Michael Catanzaro
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2018-12-19 21:03:47 PST
Created
attachment 357774
[details]
Patch
Michael Catanzaro
Comment 2
2019-01-01 12:03:26 PST
Ping reviewers
WebKit Commit Bot
Comment 3
2019-01-03 10:21:06 PST
Comment on
attachment 357774
[details]
Patch Clearing flags on attachment: 357774 Committed
r239596
: <
https://trac.webkit.org/changeset/239596
>
WebKit Commit Bot
Comment 4
2019-01-03 10:21:07 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5
2019-01-03 10:22:27 PST
<
rdar://problem/47027896
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug