Bug 192913 – UserMedia test should use WKPageNavigationClient

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Michael Catanzaro]

r239167 "On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early" introduced a deprecation warning:

[452/530] Building CXX object Tools/TestWebKitAPI/C...keFiles/TestWebKit.dir/Tests/WebKit/UserMedia.cpp.o
../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp: In member function ‘virtual void TestWebKitAPI::WebKit_OnDeviceChangeCrash_Test::TestBody()’:
../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:139:66: warning: ‘void WKPageSetPageLoaderClient(WKPageRef, const WKPageLoaderClientBase*)’ is deprecated: use WKPageSetPageNavigationClient [-Wdeprecated-declarations]
     WKPageSetPageLoaderClient(webView2.page(), &loaderClient.base);
                                                                  ^
In file included from DerivedSources/ForwardingHeaders/WebKit/WKPage.h:1,
                 from ../../Source/WebKit/UIProcess/API/C/WebKit2_C.h:53,
                 from DerivedSources/ForwardingHeaders/WebKit/WebKit2_C.h:1,
                 from ../../Tools/TestWebKitAPI/config.h:49,
                 from ../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:20:
../../Source/WebKit/UIProcess/API/C/WKPage.h:228:16: note: declared here
 WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA));
                ^~~~~~~~~~~~~~~~~~~~~~~~~
../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:139:66: warning: ‘void WKPageSetPageLoaderClient(WKPageRef, const WKPageLoaderClientBase*)’ is deprecated: use WKPageSetPageNavigationClient [-Wdeprecated-declarations]
     WKPageSetPageLoaderClient(webView2.page(), &loaderClient.base);
                                                                  ^
In file included from DerivedSources/ForwardingHeaders/WebKit/WKPage.h:1,
                 from ../../Source/WebKit/UIProcess/API/C/WebKit2_C.h:53,
                 from DerivedSources/ForwardingHeaders/WebKit/WebKit2_C.h:1,
                 from ../../Tools/TestWebKitAPI/config.h:49,
                 from ../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:20:
../../Source/WebKit/UIProcess/API/C/WKPage.h:228:16: note: declared here
 WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA));
                ^~~~~~~~~~~~~~~~~~~~~~~~~

[Michael Catanzaro]

Created attachment 357774 [details]
Patch

[Michael Catanzaro]

Ping reviewers

[WebKit Commit Bot]

Comment on attachment 357774 [details]
Patch

Clearing flags on attachment: 357774

Committed r239596: <https://trac.webkit.org/changeset/239596>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47027896>