Bug 192911 - ITMLKit Inspector: Computed Style Box Model section throws exceptions
Summary: ITMLKit Inspector: Computed Style Box Model section throws exceptions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-19 19:19 PST by Joseph Pecoraro
Modified: 2018-12-20 12:05 PST (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (6.33 KB, patch)
2018-12-19 19:23 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-12-19 19:19:16 PST 
ITMLKit Inspector: Computed Style Box Model section throws exceptions

ITMLKit doesn't always provide a display/position/width/height etc properties.

Protect against this, and just show an empty message in the box model section if those properties do not exist.
Comment 1 Radar WebKit Bug Importer 2018-12-19 19:19:37 PST 
<rdar://problem/46861112>
Comment 2 Joseph Pecoraro 2018-12-19 19:23:04 PST 
Created attachment 357771 [details]
[PATCH] Proposed Fix
Comment 3 Matt Baker 2018-12-19 19:43:56 PST 
Comment on attachment 357771 [details]
[PATCH] Proposed Fix

r=me. Nice cleanup of BoxModelDetailsSectionRow.
Comment 4 WebKit Commit Bot 2018-12-20 12:05:42 PST 
Comment on attachment 357771 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 357771

Committed r239459: <https://trac.webkit.org/changeset/239459>
Comment 5 WebKit Commit Bot 2018-12-20 12:05:43 PST 
All reviewed patches have been landed.  Closing bug.