RESOLVED FIXED 192911
ITMLKit Inspector: Computed Style Box Model section throws exceptions 
https://bugs.webkit.org/show_bug.cgi?id=192911
Summary ITMLKit Inspector: Computed Style Box Model section throws exceptions
Joseph Pecoraro
Reported 2018-12-19 19:19:16 PST
ITMLKit Inspector: Computed Style Box Model section throws exceptions ITMLKit doesn't always provide a display/position/width/height etc properties. Protect against this, and just show an empty message in the box model section if those properties do not exist.
Attachments
[PATCH] Proposed Fix (6.33 KB, patch)
2018-12-19 19:23 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-12-19 19:19:37 PST
<rdar://problem/46861112>
Joseph Pecoraro
Comment 2 2018-12-19 19:23:04 PST
Created attachment 357771 [details] [PATCH] Proposed Fix
Matt Baker
Comment 3 2018-12-19 19:43:56 PST
Comment on attachment 357771 [details] [PATCH] Proposed Fix r=me. Nice cleanup of BoxModelDetailsSectionRow.
WebKit Commit Bot
Comment 4 2018-12-20 12:05:42 PST
Comment on attachment 357771 [details] [PATCH] Proposed Fix Clearing flags on attachment: 357771 Committed r239459: <https://trac.webkit.org/changeset/239459>
WebKit Commit Bot
Comment 5 2018-12-20 12:05:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.