Adding runtime-enabled attribute to Element prevents inlining property access

[Justin Michaud]

This test <https://trac.webkit.org/browser/trunk/LayoutTests/js/dom/domjit-function-get-element-by-id.html> started failing after this patch <>.
See https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fdom%2Fdomjit-function-get-element-by-id.html

Saam suggested calling flattenDictionaryObject should fix this, and it seems to work.

[Justin Michaud]

Created attachment 357761 [details]
Patch

[Justin Michaud]

Created attachment 357778 [details]
Patch

[Saam Barati]

Comment on attachment 357778 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357778&action=review

> Source/WebCore/ChangeLog:3
> +        Adding runtime-enabled attribute to Element prevents inlining

I’d saying “inlining property access” here.

[Justin Michaud]

Created attachment 357822 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 357822 [details]
Patch

Clearing flags on attachment: 357822

Committed r239483: <https://trac.webkit.org/changeset/239483>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46888953>

[Saam Barati]

This was also a 7% progression on the "Dromaeo CSS Selector" test.

[Ryosuke Niwa]

(In reply to Saam Barati from comment #8)
> This was also a 7% progression on the "Dromaeo CSS Selector" test.

Nice!