WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
192871
Web Inspector: Elements tab: arrow key after undoing a DOM node delete selects the wrong element
https://bugs.webkit.org/show_bug.cgi?id=192871
Summary
Web Inspector: Elements tab: arrow key after undoing a DOM node delete select...
Matt Baker
Reported
2018-12-19 12:32:34 PST
Summary: Arrow key after undoing a DOM node delete selects the wrong element. Test Page: <p id="a"></p> <p id="b"></p> <p id="c"></p> Steps to Reproduce: 1. Inspect test page 2. Elements tab > select DOM node for p#b 3. Press Delete 4. DOM node for p#c selected 5. Undo 6. DOM node for p#b restored 7. Press arrow key up Actual: => DOM node for p#a selected Expected: => DOM node for p#b selected
Attachments
Patch
(1.81 KB, patch)
2018-12-19 13:50 PST
,
Matt Baker
no flags
Details
Formatted Diff
Diff
Patch for landing
(2.61 KB, patch)
2018-12-19 16:20 PST
,
Matt Baker
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2018-12-19 12:33:00 PST
<
rdar://problem/46849060
>
Matt Baker
Comment 2
2018-12-19 13:50:31 PST
Created
attachment 357716
[details]
Patch
Devin Rousso
Comment 3
2018-12-19 14:07:49 PST
Comment on
attachment 357716
[details]
Patch rs=me, nice catch :) Is it possible for us to select the item before it's been inserted? I'd assume not as the indexes would get all messed up. If so, however, we may not want to move either value if the index is selected.
Matt Baker
Comment 4
2018-12-19 16:19:52 PST
(In reply to Devin Rousso from
comment #3
)
> Comment on
attachment 357716
[details]
> Patch > > rs=me, nice catch :) > > Is it possible for us to select the item before it's been inserted? I'd > assume not as the indexes would get all messed up. If so, however, we may > not want to move either value if the index is selected.
`TreeElement.prototype.select` will return if it hasn't been attached, so it looks like we shouldn't be able to get into this state. I'll add an assert since I can't be completely sure.
Matt Baker
Comment 5
2018-12-19 16:20:00 PST
Created
attachment 357748
[details]
Patch for landing
WebKit Commit Bot
Comment 6
2018-12-19 16:46:21 PST
Comment on
attachment 357748
[details]
Patch for landing Clearing flags on attachment: 357748 Committed
r239405
: <
https://trac.webkit.org/changeset/239405
>
WebKit Commit Bot
Comment 7
2018-12-19 16:46:22 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug