Bug 192854 - ContentExtensions: DFANode.cpp:66:44: error: narrowing conversion of '-1' from 'int' to 'char' inside { }
Summary: ContentExtensions: DFANode.cpp:66:44: error: narrowing conversion of '-1' fro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Claudio Saavedra
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-19 08:12 PST by Claudio Saavedra
Modified: 2018-12-19 14:25 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.25 KB, patch)
2018-12-19 08:14 PST, Claudio Saavedra
no flags Details | Formatted Diff | Diff
Patch (1.22 KB, patch)
2018-12-19 08:17 PST, Claudio Saavedra
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2018-12-19 08:12:40 PST
ContentExtensions: DFANode.cpp:66:44: error: narrowing conversion of '-1' from 'int' to 'char' inside { }
Comment 1 Claudio Saavedra 2018-12-19 08:14:40 PST
Created attachment 357680 [details]
Patch
Comment 2 EWS Watchlist 2018-12-19 08:15:55 PST
Attachment 357680 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Claudio Saavedra 2018-12-19 08:17:44 PST
Created attachment 357681 [details]
Patch
Comment 4 WebKit Commit Bot 2018-12-19 14:24:14 PST
Comment on attachment 357681 [details]
Patch

Clearing flags on attachment: 357681

Committed r239395: <https://trac.webkit.org/changeset/239395>
Comment 5 WebKit Commit Bot 2018-12-19 14:24:16 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-12-19 14:25:33 PST
<rdar://problem/46852416>