Bug 192850 – [Web Animations] Compute animation effect timing properties in batch

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

[Web Animations] Compute animation effect timing properties in batch

[Antoine Quint]

Created attachment 357670 [details]
Patch

[Dean Jackson]

Comment on attachment 357670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357670&action=review

> Source/WebCore/animation/AnimationEffect.cpp:177
> +    BasicEffectTiming basicEffectTiming;
> +    basicEffectTiming.localTime = localTime;
> +    basicEffectTiming.endTime = endTime;
> +    basicEffectTiming.activeDuration = activeDuration;
> +    basicEffectTiming.activeTime = activeTime;
> +    basicEffectTiming.phase = phase;

Maybe make a constructor that takes these as parameters?

[Antoine Quint]

Committed r239723: <https://trac.webkit.org/changeset/239723>

[Antoine Quint]

(In reply to Dean Jackson from comment #2)
> Comment on attachment 357670 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=357670&action=review
> 
> > Source/WebCore/animation/AnimationEffect.cpp:177
> > +    BasicEffectTiming basicEffectTiming;
> > +    basicEffectTiming.localTime = localTime;
> > +    basicEffectTiming.endTime = endTime;
> > +    basicEffectTiming.activeDuration = activeDuration;
> > +    basicEffectTiming.activeTime = activeTime;
> > +    basicEffectTiming.phase = phase;
> 
> Maybe make a constructor that takes these as parameters?

Rewrote this as return { localTime, activeTime, endTime, activeDuration, phase };

[Radar WebKit Bug Importer]

<rdar://problem/47111902>