Bug 192850 - [Web Animations] Compute animation effect timing properties in batch
Summary: [Web Animations] Compute animation effect timing properties in batch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-19 05:51 PST by Antoine Quint
Modified: 2019-01-08 03:37 PST (History)
2 users (show)

See Also:

Attachments
Patch (61.16 KB, patch)
2018-12-19 06:01 PST, Antoine Quint 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-12-19 05:51:04 PST 
[Web Animations] Compute animation effect timing properties in batch
Comment 1 Antoine Quint 2018-12-19 06:01:49 PST 
Created attachment 357670 [details]
Patch
Comment 2 Dean Jackson 2019-01-07 11:45:41 PST 
Comment on attachment 357670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357670&action=review

> Source/WebCore/animation/AnimationEffect.cpp:177
> +    BasicEffectTiming basicEffectTiming;
> +    basicEffectTiming.localTime = localTime;
> +    basicEffectTiming.endTime = endTime;
> +    basicEffectTiming.activeDuration = activeDuration;
> +    basicEffectTiming.activeTime = activeTime;
> +    basicEffectTiming.phase = phase;

Maybe make a constructor that takes these as parameters?
Comment 3 Antoine Quint 2019-01-08 03:32:05 PST 
Committed r239723: <https://trac.webkit.org/changeset/239723>
Comment 4 Antoine Quint 2019-01-08 03:32:48 PST 
(In reply to Dean Jackson from comment #2)
> Comment on attachment 357670 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=357670&action=review
> 
> > Source/WebCore/animation/AnimationEffect.cpp:177
> > +    BasicEffectTiming basicEffectTiming;
> > +    basicEffectTiming.localTime = localTime;
> > +    basicEffectTiming.endTime = endTime;
> > +    basicEffectTiming.activeDuration = activeDuration;
> > +    basicEffectTiming.activeTime = activeTime;
> > +    basicEffectTiming.phase = phase;
> 
> Maybe make a constructor that takes these as parameters?

Rewrote this as return { localTime, activeTime, endTime, activeDuration, phase };
Comment 5 Radar WebKit Bug Importer 2019-01-08 03:37:05 PST 
<rdar://problem/47111902>