Bug 192845 - Web Inspector: column sort controls in Layers tab sidebar don't render correctly in dark mode
Summary: Web Inspector: column sort controls in Layers tab sidebar don't render correc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-18 22:58 PST by Nikita Vasilyev
Modified: 2018-12-19 13:09 PST (History)
4 users (show)

See Also:

Attachments
[Image] Bug (46.07 KB, image/png)
2018-12-18 22:58 PST, Nikita Vasilyev 		no flags Details
Patch (1.68 KB, patch)
2018-12-18 23:09 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Video] With patch applied (209.39 KB, video/quicktime)
2018-12-18 23:11 PST, Nikita Vasilyev 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-12-18 22:58:08 PST 
Created attachment 357659 [details]
[Image] Bug

DataGrid sort controls (up/down arrows) blend with the background.

Areas affected:
- Storage (for Local Storage and Session Storage, but not Cookies)
- Timelines
- Layers tab sidebar
Comment 1 Nikita Vasilyev 2018-12-18 23:09:16 PST 
Created attachment 357660 [details]
Patch
Comment 2 Nikita Vasilyev 2018-12-18 23:11:18 PST 
Created attachment 357661 [details]
[Video] With patch applied
Comment 3 Nikita Vasilyev 2018-12-18 23:11:40 PST 
<rdar://problem/46701530>
Comment 4 Devin Rousso 2018-12-19 12:42:30 PST 
Comment on attachment 357660 [details]
Patch

rs=me, looks nice :)
Comment 5 WebKit Commit Bot 2018-12-19 13:09:01 PST 
Comment on attachment 357660 [details]
Patch

Clearing flags on attachment: 357660

Committed r239385: <https://trac.webkit.org/changeset/239385>
Comment 6 WebKit Commit Bot 2018-12-19 13:09:03 PST 
All reviewed patches have been landed.  Closing bug.