Bug 192840 - SVGUseElement::findTarget should return nullptr when there is a cycle
Summary: SVGUseElement::findTarget should return nullptr when there is a cycle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-18 19:20 PST by Ryosuke Niwa
Modified: 2018-12-19 15:52 PST (History)
7 users (show)

See Also:


Attachments
Cleanup (2.35 KB, patch)
2018-12-18 19:49 PST, Ryosuke Niwa
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-12-18 19:20:53 PST
https://trac.webkit.org/changeset/233366 added an early return to updateShadowTree() when there is a cycle
but there is a separate cycle detection for when there is a corresponding element in SVGUseElement::findTarget.

Support detecting a cycle in SVGUseElement::findTarget to consolidate these two cycle detection code paths.
Comment 1 Ryosuke Niwa 2018-12-18 19:49:01 PST
Created attachment 357647 [details]
Cleanup
Comment 2 Tim Horton 2018-12-19 14:30:39 PST
Comment on attachment 357647 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=357647&action=review

> Source/WebCore/ChangeLog:12
> +        No new tests since there shoul be no behavioral change.

s/shoul/should/
Comment 3 Ryosuke Niwa 2018-12-19 15:51:06 PST
Committed r239402: <https://trac.webkit.org/changeset/239402>
Comment 4 Radar WebKit Bug Importer 2018-12-19 15:52:26 PST
<rdar://problem/46855832>