Bug 192837 - REGRESSION(r239134) iOS safe browsing warning unable to show details
Summary: REGRESSION(r239134) iOS safe browsing warning unable to show details
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-18 16:03 PST by Alex Christensen
Modified: 2018-12-18 21:03 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.29 KB, patch)
2018-12-18 16:04 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (3.64 KB, patch)
2018-12-18 17:15 PST, Alex Christensen 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-12-18 16:03:26 PST 
REGRESSION(r239134) iOS safe browsing warning unable to show details
Comment 1 Alex Christensen 2018-12-18 16:04:29 PST 
Created attachment 357628 [details]
Patch
Comment 2 Tim Horton 2018-12-18 16:27:13 PST 
Comment on attachment 357628 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357628&action=review

> Source/WebKit/ChangeLog:10
> +        I added a call to updateContentSize in r239134 which was necessary on watchOS but it makes iOS unable to show the details.

Why?!?!
Comment 3 Alex Christensen 2018-12-18 16:28:50 PST 
It was necessary on the watch because the content is bigger than a watch screen and you need to scroll down to see or do anything.  I don't know why setting the size on the watch twice works fine but on iOS it does not.
Comment 4 Tim Horton 2018-12-18 16:35:05 PST 
Seems like it would be good to know that? Especially since it's just "do a layout and set contentSize" which should certainly not break things?
Comment 5 Alex Christensen 2018-12-18 17:15:35 PST 
Created attachment 357637 [details]
Patch
Comment 6 Alex Christensen 2018-12-18 21:01:18 PST 
http://trac.webkit.org/r239367
Comment 7 Radar WebKit Bug Importer 2018-12-18 21:03:08 PST 
<rdar://problem/46830755>