Bug 192835 - [WebAuthN] userPresence should always be true
Summary: [WebAuthN] userPresence should always be true
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency treegraph
 
Reported: 2018-12-18 15:32 PST by Jiewen Tan
Modified: 2018-12-21 15:32 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.80 KB, patch)
2018-12-20 17:34 PST, Jiewen Tan
no flags Details | Formatted Diff | Diff
Patch (3.11 KB, patch)
2018-12-20 17:39 PST, Jiewen Tan
bfulgham: review+
Details | Formatted Diff | Diff
Patch for landing (3.14 KB, patch)
2018-12-21 14:48 PST, Jiewen Tan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2018-12-18 15:32:06 PST
In the current spec, userPresence is suggested to set to the inverse of userVerification, which doesn't comply with the CTAP spec. Details in: https://github.com/w3c/webauthn/issues/1123.
Comment 1 Jiewen Tan 2018-12-18 15:51:23 PST
<rdar://problem/46538788>
Comment 2 Jiewen Tan 2018-12-20 17:34:46 PST
Created attachment 357908 [details]
Patch
Comment 3 Jiewen Tan 2018-12-20 17:39:06 PST
Created attachment 357909 [details]
Patch
Comment 4 Jiewen Tan 2018-12-20 17:40:51 PST
My suggestion is seconded by Yubico and Microsoft directly on GitHub, and Google via email.
Comment 5 Brent Fulgham 2018-12-21 14:24:32 PST
Comment on attachment 357909 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357909&action=review

r=me

> Source/WebCore/ChangeLog:11
> +        The change is made to follow my suggestion in the issue as no one has objected it.

"After discussing with other members of the working group, we decided to make userPresence always default to true."
Comment 6 Jiewen Tan 2018-12-21 14:44:25 PST
Comment on attachment 357909 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357909&action=review

Thanks Brent for r+ this patch.

>> Source/WebCore/ChangeLog:11
>> +        The change is made to follow my suggestion in the issue as no one has objected it.
> 
> "After discussing with other members of the working group, we decided to make userPresence always default to true."

Fixed.
Comment 7 Jiewen Tan 2018-12-21 14:48:46 PST
Created attachment 357983 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2018-12-21 15:27:36 PST
Comment on attachment 357983 [details]
Patch for landing

Clearing flags on attachment: 357983

Committed r239523: <https://trac.webkit.org/changeset/239523>