Bug 192832 – Error message for `-x ** y` contains a typo.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Ross Kirsling]

Error message for `-x ** y` contains a typo.

[Ross Kirsling]

Created attachment 357623 [details]
Patch

[Ross Kirsling]

Comment on attachment 357623 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357623&action=review

> Source/JavaScriptCore/parser/Parser.cpp:3889
> -        failIfTrue(match(POW) && isUnaryOpExcludingUpdateOp(leadingTokenTypeForUnaryExpression), "Amiguous unary expression in the left hand side of the exponentiation expression; parenthesis must be used to disambiguate the expression");
> +        failIfTrue(match(POW) && isUnaryOpExcludingUpdateOp(leadingTokenTypeForUnaryExpression), "Ambiguous unary expression in the left hand side of the exponentiation expression; parenthesis must be used to disambiguate the expression");

Hmm, if we're fixing this string anyway, I suppose "parenthesis must be used" -> "parentheses must be used" would be better too...

[Saam Barati]

Comment on attachment 357623 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357623&action=review

>> Source/JavaScriptCore/parser/Parser.cpp:3889
>> +        failIfTrue(match(POW) && isUnaryOpExcludingUpdateOp(leadingTokenTypeForUnaryExpression), "Ambiguous unary expression in the left hand side of the exponentiation expression; parenthesis must be used to disambiguate the expression");
> 
> Hmm, if we're fixing this string anyway, I suppose "parenthesis must be used" -> "parentheses must be used" would be better too...

r=me with this change

[Ross Kirsling]

Created attachment 357654 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 357654 [details]
Patch for landing

Clearing flags on attachment: 357654

Committed r239370: <https://trac.webkit.org/changeset/239370>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46832408>