Bug 192832 - Error message for `-x ** y` contains a typo.
Summary: Error message for `-x ** y` contains a typo.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-18 15:25 PST by Ross Kirsling
Modified: 2018-12-18 22:38 PST (History)
7 users (show)

See Also:


Attachments
Patch (4.65 KB, patch)
2018-12-18 15:27 PST, Ross Kirsling
no flags Details | Formatted Diff | Diff
Patch for landing (4.60 KB, patch)
2018-12-18 21:58 PST, Ross Kirsling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2018-12-18 15:25:15 PST
Error message for `-x ** y` contains a typo.
Comment 1 Ross Kirsling 2018-12-18 15:27:41 PST
Created attachment 357623 [details]
Patch
Comment 2 Ross Kirsling 2018-12-18 15:31:15 PST
Comment on attachment 357623 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357623&action=review

> Source/JavaScriptCore/parser/Parser.cpp:3889
> -        failIfTrue(match(POW) && isUnaryOpExcludingUpdateOp(leadingTokenTypeForUnaryExpression), "Amiguous unary expression in the left hand side of the exponentiation expression; parenthesis must be used to disambiguate the expression");
> +        failIfTrue(match(POW) && isUnaryOpExcludingUpdateOp(leadingTokenTypeForUnaryExpression), "Ambiguous unary expression in the left hand side of the exponentiation expression; parenthesis must be used to disambiguate the expression");

Hmm, if we're fixing this string anyway, I suppose "parenthesis must be used" -> "parentheses must be used" would be better too...
Comment 3 Saam Barati 2018-12-18 21:12:10 PST
Comment on attachment 357623 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357623&action=review

>> Source/JavaScriptCore/parser/Parser.cpp:3889
>> +        failIfTrue(match(POW) && isUnaryOpExcludingUpdateOp(leadingTokenTypeForUnaryExpression), "Ambiguous unary expression in the left hand side of the exponentiation expression; parenthesis must be used to disambiguate the expression");
> 
> Hmm, if we're fixing this string anyway, I suppose "parenthesis must be used" -> "parentheses must be used" would be better too...

r=me with this change
Comment 4 Ross Kirsling 2018-12-18 21:58:49 PST
Created attachment 357654 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-12-18 22:37:55 PST
Comment on attachment 357654 [details]
Patch for landing

Clearing flags on attachment: 357654

Committed r239370: <https://trac.webkit.org/changeset/239370>
Comment 6 WebKit Commit Bot 2018-12-18 22:37:57 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-12-18 22:38:25 PST
<rdar://problem/46832408>