Bug 192827 - [MSE] Remove dead code: sourceBufferPrivateSeekToTime()
Summary: [MSE] Remove dead code: sourceBufferPrivateSeekToTime()
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
Keywords: InRadar
Depends on:
Reported: 2018-12-18 13:22 PST by Alicia Boya García
Modified: 2018-12-19 03:22 PST (History)
5 users (show)

See Also:

Patch (6.89 KB, patch)
2018-12-18 13:28 PST, Alicia Boya García
no flags Details | Formatted Diff | Diff
Patch (6.93 KB, patch)
2018-12-18 13:40 PST, Alicia Boya García
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2018-12-18 13:22:22 PST
This patch makes two dead code removal changes in

First, sourceBufferPrivateFastSeekTimeForMediaTime() is made pure
virtual in SourceBufferPrivateClient. Since SourceBufferPrivateClient
is only inherited by SourceBuffer, it makes no sense to have default
implementations there (they will never be used), moreso it being a
client interface.

Second, sourceBufferPrivateSeekToTime() is removed entirely. It used
to had an empty implementation, which SourceBuffer did not overwrite,
therefore making any calls to it useless.

All calls to sourceBufferPrivateSeekToTime() have been removed:

SourceBufferPrivateAVFObjC::seekToTime(), which was also dead code
itself, used to call this method. This patch deletes it completely.

MockSourceBufferPrivate::seekToTime(), which only called this empty
method, has also been removed along with its only usage in
Comment 1 Alicia Boya García 2018-12-18 13:28:39 PST
Created attachment 357604 [details]
Comment 2 Alicia Boya García 2018-12-18 13:40:47 PST
Created attachment 357606 [details]
Comment 3 Xabier Rodríguez Calvar 2018-12-19 02:53:33 PST
Comment on attachment 357606 [details]

r+ of me and Jer, who I think forgot to set the proper flag :)
Comment 4 WebKit Commit Bot 2018-12-19 03:20:23 PST
Comment on attachment 357606 [details]

Clearing flags on attachment: 357606

Committed r239374: <https://trac.webkit.org/changeset/239374>
Comment 5 WebKit Commit Bot 2018-12-19 03:20:25 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-12-19 03:22:30 PST