RESOLVED FIXED 192827
[MSE] Remove dead code: sourceBufferPrivateSeekToTime() 
https://bugs.webkit.org/show_bug.cgi?id=192827
Summary [MSE] Remove dead code: sourceBufferPrivateSeekToTime()
Alicia Boya García
Reported 2018-12-18 13:22:22 PST
This patch makes two dead code removal changes in SourceBufferPrivateClient: First, sourceBufferPrivateFastSeekTimeForMediaTime() is made pure virtual in SourceBufferPrivateClient. Since SourceBufferPrivateClient is only inherited by SourceBuffer, it makes no sense to have default implementations there (they will never be used), moreso it being a client interface. Second, sourceBufferPrivateSeekToTime() is removed entirely. It used to had an empty implementation, which SourceBuffer did not overwrite, therefore making any calls to it useless. All calls to sourceBufferPrivateSeekToTime() have been removed: SourceBufferPrivateAVFObjC::seekToTime(), which was also dead code itself, used to call this method. This patch deletes it completely. MockSourceBufferPrivate::seekToTime(), which only called this empty method, has also been removed along with its only usage in MockMediaSourcePrivate::seekToTime().
Attachments
Patch (6.89 KB, patch)
2018-12-18 13:28 PST, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Patch (6.93 KB, patch)
2018-12-18 13:40 PST, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2018-12-18 13:28:39 PST
Created attachment 357604 [details] Patch
Alicia Boya García
Comment 2 2018-12-18 13:40:47 PST
Created attachment 357606 [details] Patch
Xabier Rodríguez Calvar
Comment 3 2018-12-19 02:53:33 PST
Comment on attachment 357606 [details] Patch r+ of me and Jer, who I think forgot to set the proper flag :)
WebKit Commit Bot
Comment 4 2018-12-19 03:20:23 PST
Comment on attachment 357606 [details] Patch Clearing flags on attachment: 357606 Committed r239374: <https://trac.webkit.org/changeset/239374>
WebKit Commit Bot
Comment 5 2018-12-19 03:20:25 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-12-19 03:22:30 PST
<rdar://problem/46837338>
Note You need to log in before you can comment on or make changes to this bug.