RESOLVED FIXED 192815
[EME] MediaKeySystemConfiguration distinctiveIdentifier and persistentState should default to optional 
https://bugs.webkit.org/show_bug.cgi?id=192815
Summary [EME] MediaKeySystemConfiguration distinctiveIdentifier and persistentState s...
Xabier Rodríguez Calvar
Reported 2018-12-18 11:05:49 PST
[EME] MediaKeySystemConfiguration distinctiveIdentifier and persistentState should default to optional
Attachments
Patch (1.87 KB, patch)
2018-12-18 11:17 PST, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2018-12-18 11:17:18 PST
Created attachment 357585 [details] Patch
WebKit Commit Bot
Comment 2 2018-12-19 00:56:03 PST
Comment on attachment 357585 [details] Patch Clearing flags on attachment: 357585 Committed r239373: <https://trac.webkit.org/changeset/239373>
WebKit Commit Bot
Comment 3 2018-12-19 00:56:04 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-12-19 00:57:28 PST
<rdar://problem/46835043>
Darin Adler
Comment 5 2018-12-19 23:20:01 PST
Comment on attachment 357585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357585&action=review > Source/WebCore/ChangeLog:11 > + https://www.w3.org/TR/encrypted-media/#dom-mediakeysystemconfiguration > + says that distinctiveIdentifier and persistentState default to > + optional. Our implementation does not define a default leaving it > + to the first option of the enum, which currently is Required. Actually, I think it was worse than that before. Our implementation was not initializing the field, which doesn’t guarantee what it will be initialized to! We were getting a 0, but that wasn’t guaranteed.
Note You need to log in before you can comment on or make changes to this bug.