Use idiomatic const references for equality helper methods for WTF::StringView class

[David Kilzer (:ddkilzer)]

Use idiomatic const references for equality methods in WTF::StringView class.

Nearly all other `operator==(const TypeName&) const` methods use const references to avoid object copies when comparing two objects.

StringView should do the same (unless I'm forgetting why it's not doing this).

[David Kilzer (:ddkilzer)]

Created attachment 357580 [details]
Patch v1

[Darin Adler]

We don’t do this because it’s not more efficient with StringView; fits well into registers, no work required on copying in production builds. Anders Carlsson originally proposed this.

I don’t see any good reason to change this.

[David Kilzer (:ddkilzer)]

(In reply to Darin Adler from comment #2)
> We don’t do this because it’s not more efficient with StringView; fits well
> into registers, no work required on copying in production builds. Anders
> Carlsson originally proposed this.
> 
> I don’t see any good reason to change this.

Okay.