Bug 192810 – REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

The following API test appears to be a flaky failure on iOS bots:

    TestWebKitAPI._WKDownload.OriginatingWebView
        
        /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:261
        Value of: !([download originatingWebView])
          Actual: false
        Expected: true

https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/builds/1607/steps/run-api-tests/logs/stdio

[Radar WebKit Bug Importer]

<rdar://problem/46812536>

[Ryan Haddad]

It failed about 50% of the time for me locally when I ran:
run-api-tests --debug --ios-simulator _WKDownload.OriginatingWebView

[David Quesada]

When I see this fail, it doesn't appear that the originatingWebView has any remaining strong references, but is in the autorelease pool, likely as a result of handling other messages that have been sent to the UI process while the test has run. The test seems to pass (I've hit at least 20 successes in a row, compared to 3/10 successes without any changes) if I defer checking the originatingWebView to the next turn of the runloop. Patch coming up.

[David Quesada]

Created attachment 357614 [details]
Patch

[Alex Christensen]

Comment on attachment 357614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357614&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:260
> +    WTF::callOnMainThread([retainedDownload = RetainPtr<_WKDownload> { download }] {

[download = retainPtr(download)]

[David Quesada]

Created attachment 357621 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 357621 [details]
Patch for landing

Clearing flags on attachment: 357621

Committed r239359: <https://trac.webkit.org/changeset/239359>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.