Bug 192802 - [iOS] Focusing an editable element should scroll to reveal the selection
Summary: [iOS] Focusing an editable element should scroll to reveal the selection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks: 193084
  Show dependency tree / graph
 
Reported: 2018-12-17 21:55 PST by Wenson Hsieh
Modified: 2019-01-02 11:35 PST (History)
6 users (show)

See Also:

Attachments
Patch for EWS (30.65 KB, patch)
2018-12-19 22:58 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-12-17 21:55:26 PST 
It currently scrolls to the last touch location (see the FIXME in WebPage::getAssistedNodeInformation, in WebPageIOS.mm).
Comment 1 Wenson Hsieh 2018-12-17 21:55:53 PST 
<rdar://problem/46781759>
Comment 2 Wenson Hsieh 2018-12-19 22:58:37 PST 
Created attachment 357790 [details]
Patch for EWS
Comment 3 WebKit Commit Bot 2018-12-20 08:29:03 PST 
Comment on attachment 357790 [details]
Patch for EWS

Clearing flags on attachment: 357790

Committed r239441: <https://trac.webkit.org/changeset/239441>
Comment 4 WebKit Commit Bot 2018-12-20 08:29:05 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Daniel Bates 2019-01-02 11:35:43 PST 
(In reply to WebKit Commit Bot from comment #3)
> Comment on attachment 357790 [details]
> Patch for EWS
> 
> Clearing flags on attachment: 357790
> 
> Committed r239441: <https://trac.webkit.org/changeset/239441>

This broke tab cycling to offscreen <select>s. See bug #193084.