Bug 192786 - webkitpy: Ignore device type for test when using --force
Summary: webkitpy: Ignore device type for test when using --force
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-17 16:29 PST by Jonathan Bedard
Modified: 2018-12-18 11:43 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.54 KB, patch)
2018-12-17 16:37 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (3.03 KB, patch)
2018-12-17 16:50 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (3.20 KB, patch)
2018-12-18 11:04 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2018-12-17 16:29:52 PST
There are cases where a contributor may wish to ignore the device type associated with a test. This fits with the description of the existing --force flag.
Comment 1 Radar WebKit Bug Importer 2018-12-17 16:30:28 PST
<rdar://problem/46794894>
Comment 2 Jonathan Bedard 2018-12-17 16:37:46 PST
Created attachment 357498 [details]
Patch
Comment 3 Jonathan Bedard 2018-12-17 16:50:33 PST
Created attachment 357502 [details]
Patch
Comment 4 Daniel Bates 2018-12-18 10:41:53 PST
Comment on attachment 357502 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357502&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:245
> +            help="Run all tests with PASS as expected result, even those marked SKIP in the test list and run tests " + \
> +                 "on available devices, even if the device type does not match (implies --skipped=ignore)"),

The wording of this text is confusing and I had to read it over a few times for it to make sense to me. Maybe it would be clearer to write: "Run all tests with PASS as expected result, even those marked SKIP in the test list or are device-specific (implies --skipped=ignore)".
Comment 5 Daniel Bates 2018-12-18 10:42:43 PST
Comment on attachment 357502 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357502&action=review

> Tools/ChangeLog:8
> +

A good change log message describes why we are making the change in addition to what the change is.
Comment 6 Jonathan Bedard 2018-12-18 11:04:32 PST
Created attachment 357583 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2018-12-18 11:43:05 PST
Comment on attachment 357583 [details]
Patch for landing

Clearing flags on attachment: 357583

Committed r239344: <https://trac.webkit.org/changeset/239344>
Comment 8 WebKit Commit Bot 2018-12-18 11:43:06 PST
All reviewed patches have been landed.  Closing bug.