Bug 192785 – Calling setValue() while typing should invoke -textDidChangeInTextField in the injected bundle

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Wenson Hsieh]

<rdar://problem/45321184>

[Wenson Hsieh]

Created attachment 357497 [details]
Patch

[Wenson Hsieh]

Created attachment 357537 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 357537 [details]
Patch

Clearing flags on attachment: 357537

Committed r239337: <https://trac.webkit.org/changeset/239337>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Truitt Savell]

Looks like revision https://trac.webkit.org/changeset/239337/webkit 

is causing fast/forms/datalist/datalist-textinput-suggestions-order.html

to crash intermittently. 

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fforms%2Fdatalist%2Fdatalist-textinput-suggestions-order.html 

I was able to reproduce this crash with:
run-webkit-tests --root testbuild-239337 fast/forms/datalist/datalist-textinput-suggestions-order.html --iterations 500 -f 

The crash happens on r239337 but not on r239336

Crash Log:
https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r239349%20(1465)/fast/forms/datalist/datalist-textinput-suggestions-order-crash-log.txt

[Wenson Hsieh]

(In reply to Truitt Savell from comment #5)
> Looks like revision https://trac.webkit.org/changeset/239337/webkit 
> 
> is causing fast/forms/datalist/datalist-textinput-suggestions-order.html
> 
> to crash intermittently. 
> 
> History:
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=fast%2Fforms%2Fdatalist%2Fdatalist-textinput-
> suggestions-order.html 
> 
> I was able to reproduce this crash with:
> run-webkit-tests --root testbuild-239337
> fast/forms/datalist/datalist-textinput-suggestions-order.html --iterations
> 500 -f 
> 
> The crash happens on r239337 but not on r239336
> 
> Crash Log:
> https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/
> r239349%20(1465)/fast/forms/datalist/datalist-textinput-suggestions-order-
> crash-log.txt

Interesting! Taking a look now.

[Truitt Savell]

This test is affected too fast/forms/datalist/datalist-textinput-keydown.html

Hsitory:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fforms%2Fdatalist%2Fdatalist-textinput-keydown.html

same repro steps work

[Wenson Hsieh]

(In reply to Truitt Savell from comment #7)
> This test is affected too fast/forms/datalist/datalist-textinput-keydown.html
> 
> Hsitory:
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=fast%2Fforms%2Fdatalist%2Fdatalist-textinput-
> keydown.html
> 
> same repro steps work

Looks to be the same root cause — I'll fix both in https://bugs.webkit.org/show_bug.cgi?id=192836.