Bug 192780 – Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled

[Simon Fraser (smfr)]

Created attachment 357485 [details]
Patch

[Simon Fraser (smfr)]

<rdar://problem/43394387>

[EWS Watchlist]

Attachment 357485 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm:66:  Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h.  [build/version_check] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:289:  Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h.  [build/version_check] [5]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/239306/webkit

[Truitt Savell]

Looks like this revision https://trac.webkit.org/changeset/239306/webkit

has caused compositing/contents-format/subpixel-antialiased-text-enabled.html

to fail constantly on Mojave wk1. 

I was able to reproduce with:

run-webkit-tests --root testbuild-239306 compositing/contents-format/subpixel-antialiased-text-enabled.html --iterations 50 -f -1

the test fails constantly on r239306 but passes when ran on 239305.


Diff:
--- /Volumes/Data/slave/mojave-debug-tests-wk1/build/layout-test-results/compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt
+++ /Volumes/Data/slave/mojave-debug-tests-wk1/build/layout-test-results/compositing/contents-format/subpixel-antialiased-text-enabled-actual.txt
@@ -8,10 +8,6 @@
     (GraphicsLayer
       (bounds 5018.00 2018.00)
       (contentsOpaque 1)
-      (tile cache coverage 0, 0 1024 x 1024)
-      (tile size 512 x 512)
-      (top left tile 0, 0 tiles grid 2 x 2)
-      (in window 1)
       (children 3
         (GraphicsLayer
           (position 18.00 10.00)

[Simon Fraser (smfr)]

Why was EWS green? I'll fix, please don't roll out.

[Truitt Savell]

EWS was green because the failure only effected Mojave. 

History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=compositing%2Fcontents-format%2Fsubpixel-antialiased-text-enabled.html

[Simon Fraser (smfr)]

We need more EWS

[Simon Fraser (smfr)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	A	LayoutTests/platform/mac-mojave-wk1/compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt
	M	LayoutTests/ChangeLog
Committed r239338