192777 – Update defines used with AccessibilitySPI

RESOLVED FIXED 192777

Update defines used with AccessibilitySPI

https://bugs.webkit.org/show_bug.cgi?id=192777

Summary Update defines used with AccessibilitySPI

chris fleizach

Reported 2018-12-17 13:58:50 PST

Update #defines for AccessibilitySPI usage and add a feature flag for FKA

Attachments
patch (11.55 KB, patch) 2018-12-17 14:38 PST, chris fleizach	no flags	Details Formatted Diff Diff
patch (50.05 KB, patch) 2018-12-17 14:59 PST, chris fleizach	no flags	Details Formatted Diff Diff
patch (50.05 KB, patch) 2018-12-17 15:05 PST, chris fleizach	no flags	Details Formatted Diff Diff
patch (51.09 KB, patch) 2018-12-17 15:46 PST, chris fleizach	no flags	Details Formatted Diff Diff
patch (51.11 KB, patch) 2018-12-17 16:23 PST, chris fleizach	no flags	Details Formatted Diff Diff
patch (51.21 KB, patch) 2018-12-17 16:29 PST, chris fleizach	no flags	Details Formatted Diff Diff
Patch (5.34 KB, patch) 2018-12-17 17:42 PST, Tim Horton	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

chris fleizach

Comment 1 2018-12-17 14:38:11 PST

Created attachment 357477 [details] patch

EWS Watchlist

Comment 2 2018-12-17 14:40:36 PST

Attachment 357477 [details] did not pass style-queue: ERROR: Source/WebKit/Platform/spi/ios/AccessibilitySupportSPI.h:28: Header file should not contain WebCore config.h. Should be: alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebKit/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebCore/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebKit/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebKit/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebKit/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebKit/config.h:82: Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h. [build/version_check] [5] Total errors found: 7 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

chris fleizach

Comment 3 2018-12-17 14:59:02 PST

Created attachment 357481 [details] patch

EWS Watchlist

Comment 4 2018-12-17 15:02:27 PST

Attachment 357481 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

chris fleizach

Comment 5 2018-12-17 15:05:51 PST

Created attachment 357482 [details] patch

EWS Watchlist

Comment 6 2018-12-17 15:07:51 PST

Attachment 357482 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

chris fleizach

Comment 7 2018-12-17 15:46:33 PST

Created attachment 357487 [details] patch

chris fleizach

Comment 8 2018-12-17 16:23:28 PST

Created attachment 357494 [details] patch

EWS Watchlist

Comment 9 2018-12-17 16:25:19 PST

Attachment 357494 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKit/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKit/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebKit/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebKit/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebKit/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] Total errors found: 5 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.

chris fleizach

Comment 10 2018-12-17 16:29:55 PST

Created attachment 357496 [details] patch

Tim Horton

Comment 11 2018-12-17 17:42:29 PST

Created attachment 357508 [details] Patch

Simon Fraser (smfr)

Comment 12 2018-12-17 17:43:33 PST

Comment on attachment 357508 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357508&action=review > Source/WebKit/Platform/spi/ios/AccessibilitySupportSPI.h:58 > +#endif Is this // USE(APPLE_INTERNAL_SDK) ?

WebKit Commit Bot

Comment 13 2018-12-17 18:25:34 PST

Comment on attachment 357508 [details] Patch Clearing flags on attachment: 357508 Committed r239311: <https://trac.webkit.org/changeset/239311>

WebKit Commit Bot

Comment 14 2018-12-17 18:25:36 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 15 2018-12-17 18:26:25 PST

<rdar://problem/46798180>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version Other

Hardware Unspecified

OS Unspecified

Product WebKit

Component WebKit2

Assignee

Tim Horton

Reported

2018-12-17 13:58 PST

Modified

2018-12-17 18:26 PST History

CC List

14 users Show

URL

Keywords InRadar

Depends on

Blocks