Bug 192775 - webkitpy: Handle case where stdout and stderr don't accept unicode
Summary: webkitpy: Handle case where stdout and stderr don't accept unicode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-17 13:47 PST by Jonathan Bedard
Modified: 2018-12-17 16:12 PST (History)
8 users (show)

See Also:


Attachments
Patch (2.95 KB, patch)
2018-12-17 13:54 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2018-12-17 13:47:21 PST
It turns out that while the terminal accepts unicode characters, buildbot's stdout and stderr does not. We should handle this case in the MeteredStream object.
Comment 1 Radar WebKit Bug Importer 2018-12-17 13:47:43 PST
<rdar://problem/46788706>
Comment 2 Jonathan Bedard 2018-12-17 13:54:13 PST
Created attachment 357473 [details]
Patch
Comment 3 WebKit Commit Bot 2018-12-17 16:12:13 PST
Comment on attachment 357473 [details]
Patch

Clearing flags on attachment: 357473

Committed r239303: <https://trac.webkit.org/changeset/239303>
Comment 4 WebKit Commit Bot 2018-12-17 16:12:15 PST
All reviewed patches have been landed.  Closing bug.