Bug 192772 – Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

SuspendedPage's process reuse for link navigation optimization sometimes broken after r239182. In particular, if the page fails to enter page cache, we now throw away the entire process, which can slow down 'back' navigation to this HistoryItem or link navigations to the same domain.

[Chris Dumez]

Created attachment 357479 [details]
Patch

[EWS Watchlist]

Attachment 357479 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:1795:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:1802:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Comment on attachment 357479 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357479&action=review

> Source/WebKit/ChangeLog:16
> +        Address the issue by keeping the SuspendedPageProxy alive even if the WebPage fails to suspend.
> +        When trying to reuse a SuspendedPageProxy, if the page failed to suspend, reuse its process but
> +        not the suspended page itself.

As you mentioned in the original bug, a separate process cache for domains might be a nicer design. This will do though.

[WebKit Commit Bot]

Comment on attachment 357479 [details]
Patch

Clearing flags on attachment: 357479

Committed r239333: <https://trac.webkit.org/changeset/239333>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46809841>