Bug 192770 - Fix stale assertion in attemptToForceStringArrayModeByToStringConversion().
Summary: Fix stale assertion in attemptToForceStringArrayModeByToStringConversion().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-17 12:17 PST by Mark Lam
Modified: 2018-12-17 13:33 PST (History)
5 users (show)

See Also:


Attachments
proposed patch. (2.70 KB, patch)
2018-12-17 12:22 PST, Mark Lam
keith_miller: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-12-17 12:17:13 PST
<rdar://problem/46449037>
Comment 1 Mark Lam 2018-12-17 12:22:47 PST
Created attachment 357466 [details]
proposed patch.
Comment 2 Keith Miller 2018-12-17 12:52:12 PST
Comment on attachment 357466 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=357466&action=review

r=me.

> JSTests/ChangeLog:9
> +        * stress/regress-192770.js: Added.

Nit: Can we give this a real name? I kinda hate the "regress-<unclear number>.js" convention.
Comment 3 Mark Lam 2018-12-17 13:01:12 PST
Thanks for the review.

(In reply to Keith Miller from comment #2)
> Comment on attachment 357466 [details]
> proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=357466&action=review
> 
> r=me.
> 
> > JSTests/ChangeLog:9
> > +        * stress/regress-192770.js: Added.
> 
> Nit: Can we give this a real name? I kinda hate the "regress-<unclear
> number>.js" convention.

Will rename to force-string-arrayMode-on-originalNonArray-array-class.js.
Comment 4 Mark Lam 2018-12-17 13:33:10 PST
Landed in r239287: <http://trac.webkit.org/r239287>.