Bug 192756 - [LFC][BFC][MarginCollapsing] BlockFormattingState should cache the maximum positive and negative margin values for margin collapsing.
Summary: [LFC][BFC][MarginCollapsing] BlockFormattingState should cache the maximum po...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks: LFC
  Show dependency tree / graph
 
Reported: 2018-12-17 08:00 PST by zalan
Modified: 2022-10-10 09:58 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.54 KB, patch)
2018-12-17 08:05 PST, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-12-17 08:00:15 PST 
When two or more margins collapse, the resulting margin width is the maximum of the collapsing margins' widths. In the case of negative margins, the maximum of the absolute values of the negative adjoining margins is deducted from the maximum of the positive adjoining margins. If there are no positive margins, the maximum of the absolute values of the adjoining margins is deducted from zero.
Comment 1 zalan 2018-12-17 08:05:42 PST 
Created attachment 357440 [details]
Patch
Comment 2 Ahmad Saleem 2022-10-10 09:58:43 PDT 
I checked with BugID on Webkit GitHub and it seems this r+ patch didn't landed. Thanks!