Bug 192752 – [Win][Clang] Fix compilation warnings under WebCore/platform/graphics directory

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Fujii Hironori]

[Win][Clang] Fix compilation warnings WebCore/platform/graphics directory

clang-cl reports the following compilation warnings:

> ..\..\Source\WebCore\platform\graphics\win\DIBPixelData.cpp(31,19):  warning: unused variable 'bitmapType' [-Wunused-const-variable]
> ..\..\Source\WebCore\platform\graphics\win\DIBPixelData.cpp(32,19):  warning: unused variable 'bitmapPixelsPerMeter' [-Wunused-const-variable]
> ..\..\Source\WebCore\platform\graphics\win\FontPlatformDataWin.cpp(82,15):  warning: unused variable 'result' [-Wunused-variable]
> ..\..\Source\WebCore\platform\graphics\win\FontCacheWin.cpp(362,24):  warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
> ..\..\Source\WebCore\platform\graphics\win\FontCacheWin.cpp(372,24):  warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
> ..\..\Source\WebCore\platform\graphics\win\FontCacheWin.cpp(380,24):  warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
> ..\..\Source\WebCore\platform\graphics\win\FontCacheWin.cpp(382,24):  warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
> ..\..\Source\WebCore\platform\graphics\win\FontCacheWin.cpp(384,24):  warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
> ..\..\Source\WebCore\platform\graphics\win\FontCacheWin.cpp(386,24):  warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
> ..\..\Source\WebCore\platform\graphics\win\FontCacheWin.cpp(388,24):  warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
> ..\..\Source\WebCore\platform\graphics\win\GraphicsContextWin.cpp(189,21):  warning: unused variable 'deg2rad' [-Wunused-const-variable]
> ..\..\Source\WebCore\platform\graphics\win\SimpleFontDataWin.cpp(113,36):  warning: suggest braces around initialization of subobject [-Wmissing-braces]
> ..\..\Source\WebCore\platform\graphics\win\SimpleFontDataWin.cpp(113,43):  warning: suggest braces around initialization of subobject [-Wmissing-braces]
> ..\..\Source\WebCore\platform\graphics\win\SimpleFontDataWin.cpp(113,50):  warning: suggest braces around initialization of subobject [-Wmissing-braces]
> ..\..\Source\WebCore\platform\graphics\win\SimpleFontDataWin.cpp(113,57):  warning: suggest braces around initialization of subobject [-Wmissing-braces]
> ..\..\Source\WebCore\platform\graphics\win\SimpleFontDataWin.cpp(180,36):  warning: suggest braces around initialization of subobject [-Wmissing-braces]
> ..\..\Source\WebCore\platform\graphics\win\SimpleFontDataWin.cpp(180,43):  warning: suggest braces around initialization of subobject [-Wmissing-braces]
> ..\..\Source\WebCore\platform\graphics\win\SimpleFontDataWin.cpp(180,50):  warning: suggest braces around initialization of subobject [-Wmissing-braces]
> ..\..\Source\WebCore\platform\graphics\win\SimpleFontDataWin.cpp(180,57):  warning: suggest braces around initialization of subobject [-Wmissing-braces]
> ..\..\Source\WebCore\platform\graphics\win\SimpleFontDataWin.cpp(196,36):  warning: suggest braces around initialization of subobject [-Wmissing-braces]
> ..\..\Source\WebCore\platform\graphics\win\SimpleFontDataWin.cpp(196,43):  warning: suggest braces around initialization of subobject [-Wmissing-braces]
> ..\..\Source\WebCore\platform\graphics\win\SimpleFontDataWin.cpp(196,50):  warning: suggest braces around initialization of subobject [-Wmissing-braces]
> ..\..\Source\WebCore\platform\graphics\win\SimpleFontDataWin.cpp(196,57):  warning: suggest braces around initialization of subobject [-Wmissing-braces]
> ..\..\Source\WebCore\platform\graphics\win\SimpleFontDataWin.cpp(46,13):  warning: unused variable 'cSmallCapsFontSizeMultiplier' [-Wunused-const-variable]
> ..\..\Source\WebCore\platform\graphics\win\UniscribeController.cpp(53,7):  warning: field 'm_end' will be initialized after field 'm_currentCharacter' [-Wreorder]
> ..\..\Source\WebCore\platform\graphics\win\UniscribeController.cpp(90,42):  warning: '&&' within '||' [-Wlogical-op-parentheses]
> ..\..\Source\WebCore\platform\graphics\win\UniscribeController.cpp(90,74):  warning: '&&' within '||' [-Wlogical-op-parentheses]
> ..\..\Source\WebCore\platform\graphics\win\UniscribeController.cpp(201,15):  warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
> ..\..\Source\WebCore\platform\graphics\win\UniscribeController.cpp(263,9):  warning: unused variable 'glyphCount' [-Wunused-variable]
> ..\..\Source\WebCore\platform\graphics\texmap\TextureMapperGL.cpp(153,10):  warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
> ..\..\Source\WebCore\platform\graphics\win\SimpleFontDataCairoWin.cpp(119,36):  warning: suggest braces around initialization of subobject [-Wmissing-braces]
> ..\..\Source\WebCore\platform\graphics\win\SimpleFontDataCairoWin.cpp(119,43):  warning: suggest braces around initialization of subobject [-Wmissing-braces]
> ..\..\Source\WebCore\platform\graphics\win\SimpleFontDataCairoWin.cpp(119,50):  warning: suggest braces around initialization of subobject [-Wmissing-braces]
> ..\..\Source\WebCore\platform\graphics\win\SimpleFontDataCairoWin.cpp(119,57):  warning: suggest braces around initialization of subobject [-Wmissing-braces]
> ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp(98,7):  warning: field 'm_hwndVideo' will be initialized after field 'm_volume' [-Wreorder]
> ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp(255,13):  warning: unused variable 'hr' [-Wunused-variable]
> ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp(316,13):  warning: unused variable 'hr' [-Wunused-variable]
> ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp(428,13):  warning: unused variable 'hr' [-Wunused-variable]
> ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp(461,13):  warning: unused variable 'hr' [-Wunused-variable]
> ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp(907,13):  warning: unused variable 'hr' [-Wunused-variable]
> ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp(2959,17):  warning: 64 enumeration values not handled in switch: 'D3DFMT_UNKNOWN', 'D3DFMT_R8G8B8', 'D3DFMT_R5G6B5'... [-Wswitch]
> ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp(57,1):  warning: unused function 'MFCreateSampleGrabberSinkActivatePtr' [-Wunused-function]
> ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp(63,1):  warning: unused function 'MFCreateMemoryBufferPtr' [-Wunused-function]
> ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp(64,1):  warning: unused function 'MFCreateSamplePtr' [-Wunused-function]

[Fujii Hironori]

Created attachment 357432 [details]
Patch

[Don Olmstead]

Comment on attachment 357432 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357432&action=review

You aren't being consistent in your fixing of "using the result of an assignment as a condition without parentheses". I think you should probably pick the added parenthesis but not sure how this would affect the style guide here.

> Source/WebCore/platform/graphics/win/FontCacheWin.cpp:386
> +        simpleFont = fontFromDescriptionAndLogFont(fontDescription, nonClientMetrics.lfMenuFont, fallbackFontName);
> +        if (simpleFont)

Not adding parenthesis

> Source/WebCore/platform/graphics/win/UniscribeController.cpp:201
> +    while ((rc = ::ScriptItemize(cp, length, m_items.size() - 1, &m_control, &m_state, m_items.data(), &numItems)) == E_OUTOFMEMORY) {

Added parenthesis here

[Fujii Hironori]

Thank you for the review.

(In reply to Don Olmstead from comment #2)
> Comment on attachment 357432 [details]
> You aren't being consistent in your fixing of "using the result of an
> assignment as a condition without parentheses". I think you should probably
> pick the added parenthesis but not sure how this would affect the style
> guide here.

Grepping through WebKit code, there are a lot of these code. 
I think I should give -Wno-parentheses to suppress the warning.
Will revert the part of the patch.

[Fujii Hironori]

Created attachment 357510 [details]
Patch

[Don Olmstead]

r=me

[Fujii Hironori]

Comment on attachment 357510 [details]
Patch

Clearing flags on attachment: 357510

Committed r239320: <https://trac.webkit.org/changeset/239320>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46801224>