Bug 192744 - Fix occasional null-dereference crash in WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame
Summary: Fix occasional null-dereference crash in WebPageProxy::didReceiveServerRedire...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-15 15:49 PST by Alex Christensen
Modified: 2018-12-17 17:33 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.68 KB, patch)
2018-12-15 15:50 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-12-15 15:49:49 PST 
Fix occasional null-dereference crash in WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame
Comment 1 Alex Christensen 2018-12-15 15:50:55 PST 
Created attachment 357408 [details]
Patch
Comment 2 Chris Dumez 2018-12-15 16:00:24 PST 
Comment on attachment 357408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357408&action=review

> Source/WebKit/ChangeLog:5
> +        <rdar://problem/45842668>

I believe I fixed this crash in https://trac.webkit.org/changeset/238565 already, with a test.
Comment 3 Alex Christensen 2018-12-17 10:36:32 PST 
Comment on attachment 357408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357408&action=review

>> Source/WebKit/ChangeLog:5
>> +        <rdar://problem/45842668>
> 
> I believe I fixed this crash in https://trac.webkit.org/changeset/238565 already, with a test.

You did not.  This crash has been seen since then.
Comment 4 Chris Dumez 2018-12-17 15:56:31 PST 
Comment on attachment 357408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357408&action=review

>>> Source/WebKit/ChangeLog:5
>>> +        <rdar://problem/45842668>
>> 
>> I believe I fixed this crash in https://trac.webkit.org/changeset/238565 already, with a test.
> 
> You did not.  This crash has been seen since then.

Crash trace is actually different but yes.
Comment 5 WebKit Commit Bot 2018-12-17 17:32:43 PST 
Comment on attachment 357408 [details]
Patch

Clearing flags on attachment: 357408

Committed r239305: <https://trac.webkit.org/changeset/239305>
Comment 6 WebKit Commit Bot 2018-12-17 17:32:44 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-12-17 17:33:36 PST 
<rdar://problem/46796907>