RESOLVED FIXED 192744
Fix occasional null-dereference crash in WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame 
https://bugs.webkit.org/show_bug.cgi?id=192744
Summary Fix occasional null-dereference crash in WebPageProxy::didReceiveServerRedire...
Alex Christensen
Reported 2018-12-15 15:49:49 PST
Fix occasional null-dereference crash in WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame
Attachments
Patch (1.68 KB, patch)
2018-12-15 15:50 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-12-15 15:50:55 PST
Created attachment 357408 [details] Patch
Chris Dumez
Comment 2 2018-12-15 16:00:24 PST
Comment on attachment 357408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357408&action=review > Source/WebKit/ChangeLog:5 > + <rdar://problem/45842668> I believe I fixed this crash in https://trac.webkit.org/changeset/238565 already, with a test.
Alex Christensen
Comment 3 2018-12-17 10:36:32 PST
Comment on attachment 357408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357408&action=review >> Source/WebKit/ChangeLog:5 >> + <rdar://problem/45842668> > > I believe I fixed this crash in https://trac.webkit.org/changeset/238565 already, with a test. You did not. This crash has been seen since then.
Chris Dumez
Comment 4 2018-12-17 15:56:31 PST
Comment on attachment 357408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357408&action=review >>> Source/WebKit/ChangeLog:5 >>> + <rdar://problem/45842668> >> >> I believe I fixed this crash in https://trac.webkit.org/changeset/238565 already, with a test. > > You did not. This crash has been seen since then. Crash trace is actually different but yes.
WebKit Commit Bot
Comment 5 2018-12-17 17:32:43 PST
Comment on attachment 357408 [details] Patch Clearing flags on attachment: 357408 Committed r239305: <https://trac.webkit.org/changeset/239305>
WebKit Commit Bot
Comment 6 2018-12-17 17:32:44 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-12-17 17:33:36 PST
<rdar://problem/46796907>
Note You need to log in before you can comment on or make changes to this bug.