Bug 192740 - [WPE][GTK] Add libpsl to JHBuild module sets
Summary: [WPE][GTK] Add libpsl to JHBuild module sets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-15 04:37 PST by Adrian Perez
Modified: 2018-12-15 15:03 PST (History)
9 users (show)

See Also:


Attachments
Patch (2.31 KB, patch)
2018-12-15 04:42 PST, Adrian Perez
no flags Details | Formatted Diff | Diff
Patch v2 (2.32 KB, patch)
2018-12-15 07:45 PST, Adrian Perez
mcatanzaro: review+
mcatanzaro: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2018-12-15 04:37:14 PST
Most of the bots (and in particular the EWS ones!) are running on
Debian stable, which has libpsl 0.15.0; but that is too old as
the glib-networking version installed in the JHBuild requires
version 0.20.0. Unfortunately, the Debian backports repository
does not have packages for newer libpsl versions either, so we
need to add it to the JHBuild module sets for the WPE and GTK+
ports.

This is needed to unbreak our EWS bots as well.
Comment 1 Adrian Perez 2018-12-15 04:42:25 PST
Created attachment 357398 [details]
Patch
Comment 2 Adrian Perez 2018-12-15 07:45:47 PST
Created attachment 357402 [details]
Patch v2
Comment 3 Michael Catanzaro 2018-12-15 09:47:40 PST
Comment on attachment 357402 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=357402&action=review

> Tools/gtk/jhbuild.modules:235
> +      <dep package="libpsl/"/>

It's a dependency of libsoup, not glib-networking. Please fix before landing! Sorry I didn't notice this yesterday....
Comment 4 Adrian Perez 2018-12-15 15:01:48 PST
Committed r239253: <https://trac.webkit.org/changeset/239253>
Comment 5 Radar WebKit Bug Importer 2018-12-15 15:03:12 PST
<rdar://problem/46757064>