Bug 19274 - wxWebKit compile error on linux x86_64
Summary: wxWebKit compile error on linux x86_64
Status: RESOLVED DUPLICATE of bug 19310
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit wx (show other bugs)
Version: 420+
Hardware: Other Linux
: P2 Normal
Assignee: Malcolm MacLeod
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-27 12:26 PDT by Malcolm MacLeod
Modified: 2008-06-09 07:52 PDT (History)
0 users

See Also:

Attachments
Compile fix for x86_64 platforms (1.05 KB, patch)
2008-05-27 12:33 PDT, Malcolm MacLeod 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Malcolm MacLeod 2008-05-27 12:26:45 PDT 
SVN Trunk version of wxWebKit fails to compile on x86_64 platforms due to relying on a cast from pointer to int in order to generate font keys.
The attached file provides a fix that works around this.
The patch is not 100% ideal as it could lead to conflicts in keys in very rare circumstances.
Comment 1 Malcolm MacLeod 2008-05-27 12:33:34 PDT 
Created attachment 21368 [details]
Compile fix for x86_64 platforms
Comment 2 Alexey Proskuryakov 2008-05-28 06:04:52 PDT 
A better way to fix this would be by using PtrHash:

return PtrHash<wxFont*>::hash(&m_font);

This class appears broken in that it computes m_fontHash and never uses it later, and also includes hash table machinery that should be in hash traits instead, but fixing that is out of scope for a simple bug fix.

Please do not use tab characters in your patch.
Comment 3 Alexey Proskuryakov 2008-06-09 07:52:09 PDT 
Fixed by fixing the hash function itself.

*** This bug has been marked as a duplicate of 19310 ***