WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 19310
Bug 19274
wxWebKit compile error on linux x86_64
https://bugs.webkit.org/show_bug.cgi?id=19274
Summary
wxWebKit compile error on linux x86_64
Malcolm MacLeod
Reported
2008-05-27 12:26:45 PDT
SVN Trunk version of wxWebKit fails to compile on x86_64 platforms due to relying on a cast from pointer to int in order to generate font keys. The attached file provides a fix that works around this. The patch is not 100% ideal as it could lead to conflicts in keys in very rare circumstances.
Attachments
Compile fix for x86_64 platforms
(1.05 KB, patch)
2008-05-27 12:33 PDT
,
Malcolm MacLeod
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Malcolm MacLeod
Comment 1
2008-05-27 12:33:34 PDT
Created
attachment 21368
[details]
Compile fix for x86_64 platforms
Alexey Proskuryakov
Comment 2
2008-05-28 06:04:52 PDT
A better way to fix this would be by using PtrHash: return PtrHash<wxFont*>::hash(&m_font); This class appears broken in that it computes m_fontHash and never uses it later, and also includes hash table machinery that should be in hash traits instead, but fixing that is out of scope for a simple bug fix. Please do not use tab characters in your patch.
Alexey Proskuryakov
Comment 3
2008-06-09 07:52:09 PDT
Fixed by fixing the hash function itself. *** This bug has been marked as a duplicate of
19310
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug