Bug 192726 - [WebGPU] Implement WebGPUBindGroupLayoutDescriptor and its supporting dictionaries
Summary: [WebGPU] Implement WebGPUBindGroupLayoutDescriptor and its supporting diction...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-14 16:44 PST by Justin Fan
Modified: 2018-12-17 13:39 PST (History)
5 users (show)

See Also:

Attachments
Patch (30.50 KB, patch)
2018-12-14 17:01 PST, Justin Fan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-sierra-wk2 (3.32 MB, application/zip)
2018-12-14 18:00 PST, EWS Watchlist 		no flags Details
Patch for landing (30.50 KB, patch)
2018-12-14 18:06 PST, Justin Fan 		no flags Details | Formatted Diff | Diff
Patch for landing (30.54 KB, patch)
2018-12-14 18:22 PST, Justin Fan 		no flags Details | Formatted Diff | Diff
Patch for landing (30.53 KB, patch)
2018-12-17 11:04 PST, Justin Fan 		no flags Details | Formatted Diff | Diff
Patch (30.52 KB, patch)
2018-12-17 12:01 PST, Justin Fan 		no flags Details | Formatted Diff | Diff
Patch (31.53 KB, patch)
2018-12-17 12:08 PST, Justin Fan 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2018-12-14 16:44:23 PST 
[WebGPU] Implement WebGPUBindGroupLayoutDescriptor and its supporting dictionaries
Comment 1 Justin Fan 2018-12-14 17:01:55 PST 
Created attachment 357358 [details]
Patch
Comment 2 Justin Fan 2018-12-14 17:04:07 PST 
<rdar://problem/4674692>
Comment 3 Myles C. Maxfield 2018-12-14 17:06:17 PST 
Comment on attachment 357358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357358&action=review

> Source/WebCore/Modules/streams/WebGPUBindGroupLayoutDescriptor.h:34
> +using WebGPUBindGroupLayoutDescriptor = GPUBindGroupLayoutDescriptor;

Isn't this breaking the whole idea of having internal and external interfaces?

also, typedef
Comment 4 Myles C. Maxfield 2018-12-14 17:19:11 PST 
(In reply to Myles C. Maxfield from comment #3)
> Comment on attachment 357358 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=357358&action=review
> 
> > Source/WebCore/Modules/streams/WebGPUBindGroupLayoutDescriptor.h:34
> > +using WebGPUBindGroupLayoutDescriptor = GPUBindGroupLayoutDescriptor;
> 
> Isn't this breaking the whole idea of having internal and external
> interfaces?
> 
> also, typedef

Sounds like "using" is the preferred mechanism now
Comment 5 Justin Fan 2018-12-14 17:50:34 PST 
Build failure is unrelated to this change.
Comment 6 Justin Fan 2018-12-14 17:51:24 PST 
Test failure, however, is not. Woops
Comment 7 EWS Watchlist 2018-12-14 18:00:30 PST 
Comment on attachment 357358 [details]
Patch

Attachment 357358 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10405402

New failing tests:
webgpu/bind-group-layouts.html
Comment 8 EWS Watchlist 2018-12-14 18:00:33 PST 
Created attachment 357364 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 9 Justin Fan 2018-12-14 18:06:21 PST 
Created attachment 357367 [details]
Patch for landing
Comment 10 Justin Fan 2018-12-14 18:22:57 PST 
Created attachment 357371 [details]
Patch for landing
Comment 11 WebKit Commit Bot 2018-12-14 18:51:03 PST 
Comment on attachment 357371 [details]
Patch for landing

Rejecting attachment 357371 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 5000 characters of output:
ort WK_IOS_14_YES=_IOS_BEFORE_14
    export WK_IOS_BEFORE_12_11=YES
    export WK_IOS_BEFORE_13_11=YES
    export WK_IOS_BEFORE_13_12=YES
    export WK_IOS_BEFORE_14_11=YES
    export WK_IOS_BEFORE_14_12=YES
    export WK_IOS_BEFORE_14_13=YES
    export WK_IS_COCOA_TOUCH=NO
    export WK_LIBWEBRTC_LDFLAGS_ENABLE_WEB_RTC="-framework VideoToolbox -framework CoreMedia -weak-lwebrtc"
    export WK_LIBWEBRTC_LIBRARY_DIR=/System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/Frameworks
    export WK_LIBWEBRTC_LIBRARY_DIR_USE_OVERRIDE_FRAMEWORKS_DIR_NO=/System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/Frameworks
    export WK_LLVM_LTO_NO=NO
    export WK_LLVM_LTO_YES=NO
    export WK_MACOS_1013=_MACOS_BEFORE_1013
    export WK_MACOS_1013_=_MACOS_SINCE_1013
    export WK_MACOS_1013_1014=_MACOS_BEFORE_1013
    export WK_MACOS_1013_1014_=_MACOS_BEFORE_1014
    export WK_MACOS_1013_1014_YES=_MACOS_BEFORE_1013
    export WK_MACOS_1013_1015=_MACOS_BEFORE_1013
    export WK_MACOS_1013_1015_=_MACOS_BEFORE_1015
    export WK_MACOS_1013_1015_YES=_MACOS_BEFORE_1013
    export WK_MACOS_1013_YES=_MACOS_BEFORE_1013
    export WK_MACOS_1014=_MACOS_BEFORE_1014
    export WK_MACOS_1014_=_MACOS_SINCE_1014
    export WK_MACOS_1014_1015=_MACOS_BEFORE_1014
    export WK_MACOS_1014_1015_=_MACOS_BEFORE_1015
    export WK_MACOS_1014_1015_YES=_MACOS_BEFORE_1014
    export WK_MACOS_1014_YES=_MACOS_BEFORE_1014
    export WK_MACOS_1015=_MACOS_BEFORE_1015
    export WK_MACOS_1015_=_MACOS_SINCE_1015
    export WK_MACOS_1015_YES=_MACOS_BEFORE_1015
    export WK_MACOS_BEFORE_1013=YES
    export WK_MACOS_BEFORE_1013_101200=YES
    export WK_MACOS_BEFORE_1014=YES
    export WK_MACOS_BEFORE_1014_101200=YES
    export WK_MACOS_BEFORE_1014_101300=YES
    export WK_MACOS_BEFORE_1015=YES
    export WK_MACOS_BEFORE_1015_101200=YES
    export WK_MACOS_BEFORE_1015_101300=YES
    export WK_MACOS_BEFORE_1015_101400=YES
    export WK_MOBILE_CORE_SERVICES_LDFLAGS_cocoatouch="-framework MobileCoreServices"
    export WK_MOBILE_GESTALT_LDFLAGS_cocoatouch=-lMobileGestalt
    export WK_NOT_=YES
    export WK_NOT_YES=NO
    export WK_OPENGL_LDFLAGS="-framework OpenGL"
    export WK_OPENGL_LDFLAGS_appletvos="-framework OpenGLES"
    export WK_OPENGL_LDFLAGS_appletvsimulator="-framework OpenGLES"
    export WK_OPENGL_LDFLAGS_iosmac="-framework OpenGL"
    export WK_OPENGL_LDFLAGS_iphoneos="-framework OpenGLES"
    export WK_OPENGL_LDFLAGS_iphonesimulator="-framework OpenGLES"
    export WK_OPENGL_LDFLAGS_macosx="-framework OpenGL"
    export WK_OPENGL_LDFLAGS_watchos="-framework OpenGLES"
    export WK_OPENGL_LDFLAGS_watchsimulator="-framework OpenGLES"
    export WK_OVERRIDE_FRAMEWORKS_DIR_USE_STAGING_INSTALL_PATH_YES=/System/Library/StagedFrameworks/Safari
    export WK_PLATFORM_NAME=macosx
    export WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_NO=macosx
    export WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_YES=iosmac
    export WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR_YES="\"\""
    export WK_RELOCATABLE_FRAMEWORKS=YES
    export WK_RELOCATABLE_FRAMEWORK_LDFLAGS=-Wl,-not_for_dyld_shared_cache
    export WK_RELOCATABLE_FRAMEWORK_LDFLAGS_YES=-Wl,-not_for_dyld_shared_cache
    export WK_SYSTEM_CONFIGURATION_LDFLAGS="-framework SystemConfiguration"
    export WK_SYSTEM_CONFIGURATION_LDFLAGS_macosx="-framework SystemConfiguration"
    export WK_SYSTEM_PREVIEW_LDFLAGS_iphoneos="-framework CoreImage"
    export WK_SYSTEM_PREVIEW_LDFLAGS_iphonesimulator="-framework CoreImage"
    export WK_TARGET_IOS_VERSION_MAJOR=10
    export WK_URL_FORMATTING_LDFLAGS_YES="-framework URLFormatting"
    export WK_USER_LTO_MODE=NO
    export WK_USER_LTO_MODE_=NO
    export WK_USER_LTO_MODE_full=YES
    export WK_USER_LTO_MODE_none=NO
    export WK_USER_LTO_MODE_thin=YES_THIN
    export WK_USE_ALTERNATE_FRAMEWORKS_DIR=NO
    export WK_USE_OVERRIDE_FRAMEWORKS_DIR=NO
    export WK_XCODE_SUPPORTS_LTO=NO
    export WK_XCODE_VERSION_BEFORE_9_0700=YES
    export WK_XCODE_VERSION_BEFORE_9_0800=YES
    export WRAP_ASSET_PACKS_IN_SEPARATE_DIRECTORIES=NO
    export XCODE_APP_SUPPORT_DIR=/Applications/Xcode.app/Contents/Developer/Library/Xcode
    export XCODE_PRODUCT_BUILD_VERSION=8E3004b
    export XCODE_VERSION_ACTUAL=0833
    export XCODE_VERSION_MAJOR=0800
    export XCODE_VERSION_MINOR=0830
    export XPCSERVICES_FOLDER_PATH=/XPCServices
    export YACC=yacc
    export arch=x86_64
    export variant=normal
    /bin/sh -c \"/Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/Derived\ Sources.build/Script-DD041FBD09D9DDBE0010AF2A.sh\"
make: *** No rule to make target `JSWebKitPlaybackTargetAvailabilityEvent.h', needed by `all'.  Stop.
Command /bin/sh failed with exit code 2

** BUILD FAILED **


The following build commands failed:
	PhaseScriptExecution Generate\ Derived\ Sources /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/Derived\ Sources.build/Script-DD041FBD09D9DDBE0010AF2A.sh
(1 failure)

Full output: https://webkit-queues.webkit.org/results/10406588
Comment 12 Justin Fan 2018-12-17 11:04:21 PST 
Created attachment 357453 [details]
Patch for landing
Comment 13 WebKit Commit Bot 2018-12-17 11:31:14 PST 
Comment on attachment 357453 [details]
Patch for landing

Rejecting attachment 357453 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 5000 characters of output:
OpenGL"
    export WK_OPENGL_LDFLAGS_iphoneos="-framework OpenGLES"
    export WK_OPENGL_LDFLAGS_iphonesimulator="-framework OpenGLES"
    export WK_OPENGL_LDFLAGS_macosx="-framework OpenGL"
    export WK_OPENGL_LDFLAGS_watchos="-framework OpenGLES"
    export WK_OPENGL_LDFLAGS_watchsimulator="-framework OpenGLES"
    export WK_OVERRIDE_FRAMEWORKS_DIR_USE_STAGING_INSTALL_PATH_YES=/System/Library/StagedFrameworks/Safari
    export WK_PLATFORM_NAME=macosx
    export WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_NO=macosx
    export WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_YES=iosmac
    export WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR_YES="\"\""
    export WK_RELOCATABLE_FRAMEWORKS=YES
    export WK_RELOCATABLE_FRAMEWORK_LDFLAGS=-Wl,-not_for_dyld_shared_cache
    export WK_RELOCATABLE_FRAMEWORK_LDFLAGS_YES=-Wl,-not_for_dyld_shared_cache
    export WK_SYSTEM_CONFIGURATION_LDFLAGS="-framework SystemConfiguration"
    export WK_SYSTEM_CONFIGURATION_LDFLAGS_macosx="-framework SystemConfiguration"
    export WK_SYSTEM_PREVIEW_LDFLAGS_iphoneos="-framework CoreImage"
    export WK_SYSTEM_PREVIEW_LDFLAGS_iphonesimulator="-framework CoreImage"
    export WK_TARGET_IOS_VERSION_MAJOR=10
    export WK_URL_FORMATTING_LDFLAGS_YES="-framework URLFormatting"
    export WK_USER_LTO_MODE=NO
    export WK_USER_LTO_MODE_=NO
    export WK_USER_LTO_MODE_full=YES
    export WK_USER_LTO_MODE_none=NO
    export WK_USER_LTO_MODE_thin=YES_THIN
    export WK_USE_ALTERNATE_FRAMEWORKS_DIR=NO
    export WK_USE_OVERRIDE_FRAMEWORKS_DIR=NO
    export WK_XCODE_SUPPORTS_LTO=NO
    export WK_XCODE_VERSION_BEFORE_9_0700=YES
    export WK_XCODE_VERSION_BEFORE_9_0800=YES
    export WRAP_ASSET_PACKS_IN_SEPARATE_DIRECTORIES=NO
    export XCODE_APP_SUPPORT_DIR=/Applications/Xcode.app/Contents/Developer/Library/Xcode
    export XCODE_PRODUCT_BUILD_VERSION=8E3004b
    export XCODE_VERSION_ACTUAL=0833
    export XCODE_VERSION_MAJOR=0800
    export XCODE_VERSION_MINOR=0830
    export XPCSERVICES_FOLDER_PATH=/XPCServices
    export YACC=yacc
    export arch=x86_64
    export variant=normal
    /bin/sh -c \"/Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/Derived\ Sources.build/Script-DD041FBD09D9DDBE0010AF2A.sh\"
make: *** No rule to make target `JSWebKitPlaybackTargetAvailabilityEvent.h', needed by `all'.  Stop.
Command /bin/sh failed with exit code 2

** BUILD FAILED **


The following build commands failed:
	PhaseScriptExecution Generate\ Derived\ Sources /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/Derived\ Sources.build/Script-DD041FBD09D9DDBE0010AF2A.sh
(1 failure)

Failed to run "['Tools/Scripts/build-webkit', '--release']" exit_code: 65
 export WK_OPENGL_LDFLAGS_watchsimulator="-framework OpenGLES"
    export WK_OVERRIDE_FRAMEWORKS_DIR_USE_STAGING_INSTALL_PATH_YES=/System/Library/StagedFrameworks/Safari
    export WK_PLATFORM_NAME=macosx
    export WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_NO=macosx
    export WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_YES=iosmac
    export WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR_YES="\"\""
    export WK_RELOCATABLE_FRAMEWORKS=YES
    export WK_RELOCATABLE_FRAMEWORK_LDFLAGS=-Wl,-not_for_dyld_shared_cache
    export WK_RELOCATABLE_FRAMEWORK_LDFLAGS_YES=-Wl,-not_for_dyld_shared_cache
    export WK_SYSTEM_CONFIGURATION_LDFLAGS="-framework SystemConfiguration"
    export WK_SYSTEM_CONFIGURATION_LDFLAGS_macosx="-framework SystemConfiguration"
    export WK_SYSTEM_PREVIEW_LDFLAGS_iphoneos="-framework CoreImage"
    export WK_SYSTEM_PREVIEW_LDFLAGS_iphonesimulator="-framework CoreImage"
    export WK_TARGET_IOS_VERSION_MAJOR=10
    export WK_URL_FORMATTING_LDFLAGS_YES="-framework URLFormatting"
    export WK_USER_LTO_MODE=NO
    export WK_USER_LTO_MODE_=NO
    export WK_USER_LTO_MODE_full=YES
    export WK_USER_LTO_MODE_none=NO
    export WK_USER_LTO_MODE_thin=YES_THIN
    export WK_USE_ALTERNATE_FRAMEWORKS_DIR=NO
    export WK_USE_OVERRIDE_FRAMEWORKS_DIR=NO
    export WK_XCODE_SUPPORTS_LTO=NO
    export WK_XCODE_VERSION_BEFORE_9_0700=YES
    export WK_XCODE_VERSION_BEFORE_9_0800=YES
    export WRAP_ASSET_PACKS_IN_SEPARATE_DIRECTORIES=NO
    export XCODE_APP_SUPPORT_DIR=/Applications/Xcode.app/Contents/Developer/Library/Xcode
    export XCODE_PRODUCT_BUILD_VERSION=8E3004b
    export XCODE_VERSION_ACTUAL=0833
    export XCODE_VERSION_MAJOR=0800
    export XCODE_VERSION_MINOR=0830
    export XPCSERVICES_FOLDER_PATH=/XPCServices
    export YACC=yacc
    export arch=x86_64
    export variant=normal
    /bin/sh -c \"/Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/Derived\ Sources.build/Script-DD041FBD09D9DDBE0010AF2A.sh\"
make: *** No rule to make target `JSWebKitPlaybackTargetAvailabilityEvent.h', needed by `all'.  Stop.
Command /bin/sh failed with exit code 2

** BUILD FAILED **


The following build commands failed:
	PhaseScriptExecution Generate\ Derived\ Sources /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/Derived\ Sources.build/Script-DD041FBD09D9DDBE0010AF2A.sh
(1 failure)

Full output: https://webkit-queues.webkit.org/results/10441407
Comment 14 Justin Fan 2018-12-17 12:01:31 PST 
Created attachment 357463 [details]
Patch
Comment 15 Justin Fan 2018-12-17 12:08:25 PST 
Created attachment 357465 [details]
Patch
Comment 16 WebKit Commit Bot 2018-12-17 13:34:25 PST 
Comment on attachment 357465 [details]
Patch

Clearing flags on attachment: 357465

Committed r239288: <https://trac.webkit.org/changeset/239288>
Comment 17 WebKit Commit Bot 2018-12-17 13:34:27 PST 
All reviewed patches have been landed.  Closing bug.
Comment 18 Justin Fan 2018-12-17 13:39:14 PST 
<rdar://problem/46746922>