Bug 192726 – [WebGPU] Implement WebGPUBindGroupLayoutDescriptor and its supporting dictionaries

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Justin Fan]

[WebGPU] Implement WebGPUBindGroupLayoutDescriptor and its supporting dictionaries

[Justin Fan]

Created attachment 357358 [details]
Patch

[Justin Fan]

<rdar://problem/4674692>

[Myles C. Maxfield]

Comment on attachment 357358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357358&action=review

> Source/WebCore/Modules/streams/WebGPUBindGroupLayoutDescriptor.h:34
> +using WebGPUBindGroupLayoutDescriptor = GPUBindGroupLayoutDescriptor;

Isn't this breaking the whole idea of having internal and external interfaces?

also, typedef

[Myles C. Maxfield]

(In reply to Myles C. Maxfield from comment #3)
> Comment on attachment 357358 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=357358&action=review
> 
> > Source/WebCore/Modules/streams/WebGPUBindGroupLayoutDescriptor.h:34
> > +using WebGPUBindGroupLayoutDescriptor = GPUBindGroupLayoutDescriptor;
> 
> Isn't this breaking the whole idea of having internal and external
> interfaces?
> 
> also, typedef

Sounds like "using" is the preferred mechanism now

[Justin Fan]

Build failure is unrelated to this change.

[Justin Fan]

Test failure, however, is not. Woops

[EWS Watchlist]

Comment on attachment 357358 [details]
Patch

Attachment 357358 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10405402

New failing tests:
webgpu/bind-group-layouts.html

[EWS Watchlist]

Created attachment 357364 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Justin Fan]

Created attachment 357367 [details]
Patch for landing

[Justin Fan]

Created attachment 357371 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 357371 [details]
Patch for landing

Rejecting attachment 357371 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 5000 characters of output:
ort WK_IOS_14_YES=_IOS_BEFORE_14
    export WK_IOS_BEFORE_12_11=YES
    export WK_IOS_BEFORE_13_11=YES
    export WK_IOS_BEFORE_13_12=YES
    export WK_IOS_BEFORE_14_11=YES
    export WK_IOS_BEFORE_14_12=YES
    export WK_IOS_BEFORE_14_13=YES
    export WK_IS_COCOA_TOUCH=NO
    export WK_LIBWEBRTC_LDFLAGS_ENABLE_WEB_RTC="-framework VideoToolbox -framework CoreMedia -weak-lwebrtc"
    export WK_LIBWEBRTC_LIBRARY_DIR=/System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/Frameworks
    export WK_LIBWEBRTC_LIBRARY_DIR_USE_OVERRIDE_FRAMEWORKS_DIR_NO=/System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/Frameworks
    export WK_LLVM_LTO_NO=NO
    export WK_LLVM_LTO_YES=NO
    export WK_MACOS_1013=_MACOS_BEFORE_1013
    export WK_MACOS_1013_=_MACOS_SINCE_1013
    export WK_MACOS_1013_1014=_MACOS_BEFORE_1013
    export WK_MACOS_1013_1014_=_MACOS_BEFORE_1014
    export WK_MACOS_1013_1014_YES=_MACOS_BEFORE_1013
    export WK_MACOS_1013_1015=_MACOS_BEFORE_1013
    export WK_MACOS_1013_1015_=_MACOS_BEFORE_1015
    export WK_MACOS_1013_1015_YES=_MACOS_BEFORE_1013
    export WK_MACOS_1013_YES=_MACOS_BEFORE_1013
    export WK_MACOS_1014=_MACOS_BEFORE_1014
    export WK_MACOS_1014_=_MACOS_SINCE_1014
    export WK_MACOS_1014_1015=_MACOS_BEFORE_1014
    export WK_MACOS_1014_1015_=_MACOS_BEFORE_1015
    export WK_MACOS_1014_1015_YES=_MACOS_BEFORE_1014
    export WK_MACOS_1014_YES=_MACOS_BEFORE_1014
    export WK_MACOS_1015=_MACOS_BEFORE_1015
    export WK_MACOS_1015_=_MACOS_SINCE_1015
    export WK_MACOS_1015_YES=_MACOS_BEFORE_1015
    export WK_MACOS_BEFORE_1013=YES
    export WK_MACOS_BEFORE_1013_101200=YES
    export WK_MACOS_BEFORE_1014=YES
    export WK_MACOS_BEFORE_1014_101200=YES
    export WK_MACOS_BEFORE_1014_101300=YES
    export WK_MACOS_BEFORE_1015=YES
    export WK_MACOS_BEFORE_1015_101200=YES
    export WK_MACOS_BEFORE_1015_101300=YES
    export WK_MACOS_BEFORE_1015_101400=YES
    export WK_MOBILE_CORE_SERVICES_LDFLAGS_cocoatouch="-framework MobileCoreServices"
    export WK_MOBILE_GESTALT_LDFLAGS_cocoatouch=-lMobileGestalt
    export WK_NOT_=YES
    export WK_NOT_YES=NO
    export WK_OPENGL_LDFLAGS="-framework OpenGL"
    export WK_OPENGL_LDFLAGS_appletvos="-framework OpenGLES"
    export WK_OPENGL_LDFLAGS_appletvsimulator="-framework OpenGLES"
    export WK_OPENGL_LDFLAGS_iosmac="-framework OpenGL"
    export WK_OPENGL_LDFLAGS_iphoneos="-framework OpenGLES"
    export WK_OPENGL_LDFLAGS_iphonesimulator="-framework OpenGLES"
    export WK_OPENGL_LDFLAGS_macosx="-framework OpenGL"
    export WK_OPENGL_LDFLAGS_watchos="-framework OpenGLES"
    export WK_OPENGL_LDFLAGS_watchsimulator="-framework OpenGLES"
    export WK_OVERRIDE_FRAMEWORKS_DIR_USE_STAGING_INSTALL_PATH_YES=/System/Library/StagedFrameworks/Safari
    export WK_PLATFORM_NAME=macosx
    export WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_NO=macosx
    export WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_YES=iosmac
    export WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR_YES="\"\""
    export WK_RELOCATABLE_FRAMEWORKS=YES
    export WK_RELOCATABLE_FRAMEWORK_LDFLAGS=-Wl,-not_for_dyld_shared_cache
    export WK_RELOCATABLE_FRAMEWORK_LDFLAGS_YES=-Wl,-not_for_dyld_shared_cache
    export WK_SYSTEM_CONFIGURATION_LDFLAGS="-framework SystemConfiguration"
    export WK_SYSTEM_CONFIGURATION_LDFLAGS_macosx="-framework SystemConfiguration"
    export WK_SYSTEM_PREVIEW_LDFLAGS_iphoneos="-framework CoreImage"
    export WK_SYSTEM_PREVIEW_LDFLAGS_iphonesimulator="-framework CoreImage"
    export WK_TARGET_IOS_VERSION_MAJOR=10
    export WK_URL_FORMATTING_LDFLAGS_YES="-framework URLFormatting"
    export WK_USER_LTO_MODE=NO
    export WK_USER_LTO_MODE_=NO
    export WK_USER_LTO_MODE_full=YES
    export WK_USER_LTO_MODE_none=NO
    export WK_USER_LTO_MODE_thin=YES_THIN
    export WK_USE_ALTERNATE_FRAMEWORKS_DIR=NO
    export WK_USE_OVERRIDE_FRAMEWORKS_DIR=NO
    export WK_XCODE_SUPPORTS_LTO=NO
    export WK_XCODE_VERSION_BEFORE_9_0700=YES
    export WK_XCODE_VERSION_BEFORE_9_0800=YES
    export WRAP_ASSET_PACKS_IN_SEPARATE_DIRECTORIES=NO
    export XCODE_APP_SUPPORT_DIR=/Applications/Xcode.app/Contents/Developer/Library/Xcode
    export XCODE_PRODUCT_BUILD_VERSION=8E3004b
    export XCODE_VERSION_ACTUAL=0833
    export XCODE_VERSION_MAJOR=0800
    export XCODE_VERSION_MINOR=0830
    export XPCSERVICES_FOLDER_PATH=/XPCServices
    export YACC=yacc
    export arch=x86_64
    export variant=normal
    /bin/sh -c \"/Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/Derived\ Sources.build/Script-DD041FBD09D9DDBE0010AF2A.sh\"
make: *** No rule to make target `JSWebKitPlaybackTargetAvailabilityEvent.h', needed by `all'.  Stop.
Command /bin/sh failed with exit code 2

** BUILD FAILED **


The following build commands failed:
	PhaseScriptExecution Generate\ Derived\ Sources /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/Derived\ Sources.build/Script-DD041FBD09D9DDBE0010AF2A.sh
(1 failure)

Full output: https://webkit-queues.webkit.org/results/10406588

[Justin Fan]

Created attachment 357453 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 357453 [details]
Patch for landing

Rejecting attachment 357453 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 5000 characters of output:
OpenGL"
    export WK_OPENGL_LDFLAGS_iphoneos="-framework OpenGLES"
    export WK_OPENGL_LDFLAGS_iphonesimulator="-framework OpenGLES"
    export WK_OPENGL_LDFLAGS_macosx="-framework OpenGL"
    export WK_OPENGL_LDFLAGS_watchos="-framework OpenGLES"
    export WK_OPENGL_LDFLAGS_watchsimulator="-framework OpenGLES"
    export WK_OVERRIDE_FRAMEWORKS_DIR_USE_STAGING_INSTALL_PATH_YES=/System/Library/StagedFrameworks/Safari
    export WK_PLATFORM_NAME=macosx
    export WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_NO=macosx
    export WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_YES=iosmac
    export WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR_YES="\"\""
    export WK_RELOCATABLE_FRAMEWORKS=YES
    export WK_RELOCATABLE_FRAMEWORK_LDFLAGS=-Wl,-not_for_dyld_shared_cache
    export WK_RELOCATABLE_FRAMEWORK_LDFLAGS_YES=-Wl,-not_for_dyld_shared_cache
    export WK_SYSTEM_CONFIGURATION_LDFLAGS="-framework SystemConfiguration"
    export WK_SYSTEM_CONFIGURATION_LDFLAGS_macosx="-framework SystemConfiguration"
    export WK_SYSTEM_PREVIEW_LDFLAGS_iphoneos="-framework CoreImage"
    export WK_SYSTEM_PREVIEW_LDFLAGS_iphonesimulator="-framework CoreImage"
    export WK_TARGET_IOS_VERSION_MAJOR=10
    export WK_URL_FORMATTING_LDFLAGS_YES="-framework URLFormatting"
    export WK_USER_LTO_MODE=NO
    export WK_USER_LTO_MODE_=NO
    export WK_USER_LTO_MODE_full=YES
    export WK_USER_LTO_MODE_none=NO
    export WK_USER_LTO_MODE_thin=YES_THIN
    export WK_USE_ALTERNATE_FRAMEWORKS_DIR=NO
    export WK_USE_OVERRIDE_FRAMEWORKS_DIR=NO
    export WK_XCODE_SUPPORTS_LTO=NO
    export WK_XCODE_VERSION_BEFORE_9_0700=YES
    export WK_XCODE_VERSION_BEFORE_9_0800=YES
    export WRAP_ASSET_PACKS_IN_SEPARATE_DIRECTORIES=NO
    export XCODE_APP_SUPPORT_DIR=/Applications/Xcode.app/Contents/Developer/Library/Xcode
    export XCODE_PRODUCT_BUILD_VERSION=8E3004b
    export XCODE_VERSION_ACTUAL=0833
    export XCODE_VERSION_MAJOR=0800
    export XCODE_VERSION_MINOR=0830
    export XPCSERVICES_FOLDER_PATH=/XPCServices
    export YACC=yacc
    export arch=x86_64
    export variant=normal
    /bin/sh -c \"/Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/Derived\ Sources.build/Script-DD041FBD09D9DDBE0010AF2A.sh\"
make: *** No rule to make target `JSWebKitPlaybackTargetAvailabilityEvent.h', needed by `all'.  Stop.
Command /bin/sh failed with exit code 2

** BUILD FAILED **


The following build commands failed:
	PhaseScriptExecution Generate\ Derived\ Sources /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/Derived\ Sources.build/Script-DD041FBD09D9DDBE0010AF2A.sh
(1 failure)

Failed to run "['Tools/Scripts/build-webkit', '--release']" exit_code: 65
 export WK_OPENGL_LDFLAGS_watchsimulator="-framework OpenGLES"
    export WK_OVERRIDE_FRAMEWORKS_DIR_USE_STAGING_INSTALL_PATH_YES=/System/Library/StagedFrameworks/Safari
    export WK_PLATFORM_NAME=macosx
    export WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_NO=macosx
    export WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_YES=iosmac
    export WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR_YES="\"\""
    export WK_RELOCATABLE_FRAMEWORKS=YES
    export WK_RELOCATABLE_FRAMEWORK_LDFLAGS=-Wl,-not_for_dyld_shared_cache
    export WK_RELOCATABLE_FRAMEWORK_LDFLAGS_YES=-Wl,-not_for_dyld_shared_cache
    export WK_SYSTEM_CONFIGURATION_LDFLAGS="-framework SystemConfiguration"
    export WK_SYSTEM_CONFIGURATION_LDFLAGS_macosx="-framework SystemConfiguration"
    export WK_SYSTEM_PREVIEW_LDFLAGS_iphoneos="-framework CoreImage"
    export WK_SYSTEM_PREVIEW_LDFLAGS_iphonesimulator="-framework CoreImage"
    export WK_TARGET_IOS_VERSION_MAJOR=10
    export WK_URL_FORMATTING_LDFLAGS_YES="-framework URLFormatting"
    export WK_USER_LTO_MODE=NO
    export WK_USER_LTO_MODE_=NO
    export WK_USER_LTO_MODE_full=YES
    export WK_USER_LTO_MODE_none=NO
    export WK_USER_LTO_MODE_thin=YES_THIN
    export WK_USE_ALTERNATE_FRAMEWORKS_DIR=NO
    export WK_USE_OVERRIDE_FRAMEWORKS_DIR=NO
    export WK_XCODE_SUPPORTS_LTO=NO
    export WK_XCODE_VERSION_BEFORE_9_0700=YES
    export WK_XCODE_VERSION_BEFORE_9_0800=YES
    export WRAP_ASSET_PACKS_IN_SEPARATE_DIRECTORIES=NO
    export XCODE_APP_SUPPORT_DIR=/Applications/Xcode.app/Contents/Developer/Library/Xcode
    export XCODE_PRODUCT_BUILD_VERSION=8E3004b
    export XCODE_VERSION_ACTUAL=0833
    export XCODE_VERSION_MAJOR=0800
    export XCODE_VERSION_MINOR=0830
    export XPCSERVICES_FOLDER_PATH=/XPCServices
    export YACC=yacc
    export arch=x86_64
    export variant=normal
    /bin/sh -c \"/Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/Derived\ Sources.build/Script-DD041FBD09D9DDBE0010AF2A.sh\"
make: *** No rule to make target `JSWebKitPlaybackTargetAvailabilityEvent.h', needed by `all'.  Stop.
Command /bin/sh failed with exit code 2

** BUILD FAILED **


The following build commands failed:
	PhaseScriptExecution Generate\ Derived\ Sources /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/Derived\ Sources.build/Script-DD041FBD09D9DDBE0010AF2A.sh
(1 failure)

Full output: https://webkit-queues.webkit.org/results/10441407

[Justin Fan]

Created attachment 357463 [details]
Patch

[Justin Fan]

Created attachment 357465 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 357465 [details]
Patch

Clearing flags on attachment: 357465

Committed r239288: <https://trac.webkit.org/changeset/239288>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Justin Fan]

<rdar://problem/46746922>