Avoid creating and evaluating in the InspectorOverlay page on iOS as it is unused Noticed this when enabling rulers, which don't show on iOS, but I saw lots of time spent updating rulers in JavaScript profiling.
<rdar://problem/46745911>
Created attachment 357354 [details] [PATCH] Proposed Fix
Comment on attachment 357354 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=357354&action=review rs=me, good catch! > Source/WebCore/inspector/InspectorOverlay.cpp:183 > + Page* overlayPage = this->overlayPage(); Is this actually reachable on iOS? I'd expect `InspectorOverlay::paint` (which is called from `InspectorController::drawHighlight`, which is called from `WebInspectorClient::drawRect`) to not happen on iOS, since it doesn't actually involve creating a `PageOverlay`?
(In reply to Devin Rousso from comment #3) > Comment on attachment 357354 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=357354&action=review > > rs=me, good catch! > > > Source/WebCore/inspector/InspectorOverlay.cpp:183 > > + Page* overlayPage = this->overlayPage(); > > Is this actually reachable on iOS? I'd expect `InspectorOverlay::paint` > (which is called from `InspectorController::drawHighlight`, which is called > from `WebInspectorClient::drawRect`) to not happen on iOS, since it doesn't > actually involve creating a `PageOverlay`? I don't think it is but I just want this code to be safe.
Comment on attachment 357354 [details] [PATCH] Proposed Fix Clearing flags on attachment: 357354 Committed r239247: <https://trac.webkit.org/changeset/239247>
All reviewed patches have been landed. Closing bug.