RESOLVED FIXED Bug 192722
[WebAuthN] Support Attestation Conveyance Preference 
https://bugs.webkit.org/show_bug.cgi?id=192722
Summary [WebAuthN] Support Attestation Conveyance Preference
Jiewen Tan
Reported 2018-12-14 16:14:58 PST
Support Attestation Conveyance Preference: https://www.w3.org/TR/webauthn/#attestation-convey.
Attachments
Patch (58.53 KB, patch)
2019-05-22 02:06 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2019-04-18 13:33:00 PDT
*** Bug 196969 has been marked as a duplicate of this bug. ***
Jiewen Tan
Comment 2 2019-05-22 01:51:31 PDT
<rdar://problem/49939647>
Jiewen Tan
Comment 3 2019-05-22 02:06:20 PDT
Created attachment 370389 [details] Patch
EWS Watchlist
Comment 4 2019-05-22 02:08:25 PDT
Attachment 370389 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/webauthn/fido/DeviceResponseConverter.h:52: The parameter name "attestation" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/Modules/webauthn/fido/U2fResponseConverter.h:42: The parameter name "attestation" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 5 2019-05-22 08:02:27 PDT
Comment on attachment 370389 [details] Patch R= me
Jiewen Tan
Comment 6 2019-05-22 11:56:32 PDT
(In reply to Brent Fulgham from comment #5) > Comment on attachment 370389 [details] > Patch > > R= me Thanks Brent for r+ this patch.
WebKit Commit Bot
Comment 7 2019-05-22 12:27:55 PDT
Comment on attachment 370389 [details] Patch Clearing flags on attachment: 370389 Committed r245638: <https://trac.webkit.org/changeset/245638>
WebKit Commit Bot
Comment 8 2019-05-22 12:27:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-05-22 12:28:18 PDT Comment hidden (obsolete)
Note You need to log in before you can comment on or make changes to this bug.