Bug 192721 - Bindings generator should support Conditional= along with CachedAttribute
Summary: Bindings generator should support Conditional= along with CachedAttribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Michaud
URL:
Keywords: InRadar
Depends on:
Blocks: 192671
  Show dependency tree / graph
 
Reported: 2018-12-14 16:01 PST by Justin Michaud
Modified: 2018-12-17 20:19 PST (History)
7 users (show)

See Also:

Attachments
Patch (8.20 KB, patch)
2018-12-14 16:19 PST, Justin Michaud 		no flags Details | Formatted Diff | Diff
Patch (8.20 KB, patch)
2018-12-17 18:38 PST, Justin Michaud 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Michaud 2018-12-14 16:01:02 PST 
Bindings generator should support Conditional= along with CachedAttribute
Comment 1 Justin Michaud 2018-12-14 16:19:19 PST 
Created attachment 357353 [details]
Patch
Comment 2 Ryosuke Niwa 2018-12-17 18:26:27 PST 
Comment on attachment 357353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357353&action=review

> Source/WebCore/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).

This line should appear after the URL but before the long description.
Comment 3 Justin Michaud 2018-12-17 18:38:45 PST 
Created attachment 357513 [details]
Patch
Comment 4 WebKit Commit Bot 2018-12-17 20:18:06 PST 
Comment on attachment 357513 [details]
Patch

Clearing flags on attachment: 357513

Committed r239316: <https://trac.webkit.org/changeset/239316>
Comment 5 WebKit Commit Bot 2018-12-17 20:18:07 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-12-17 20:19:26 PST 
<rdar://problem/46799990>