192703 – Add a style checker rule for Xcode version macros use

Bug 192703 - Add a style checker rule for Xcode version macros use

Summary: Add a style checker rule for Xcode version macros use

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Tools / Tests (show other bugs)
Version:	Other
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Alexey Proskuryakov

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2018-12-14 09:46 PST by Alexey Proskuryakov
Modified:	2020-03-26 09:24 PDT (History)
CC List:	7 users (show)

See Also:

Attachments
proposed patch (6.49 KB, patch) 2018-12-14 09:48 PST, Alexey Proskuryakov	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexey Proskuryakov 2018-12-14 09:46:06 PST

Check MIX_REQUIRED and MAX_ALLOWED family of macros.

Comment 1 Alexey Proskuryakov 2018-12-14 09:48:45 PST

Created attachment 357320 [details]
proposed patch

Comment 2 WebKit Commit Bot 2018-12-14 23:52:03 PST

Comment on attachment 357320 [details]
proposed patch

Clearing flags on attachment: 357320

Committed r239250: <https://trac.webkit.org/changeset/239250>

Comment 3 WebKit Commit Bot 2018-12-14 23:52:04 PST

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2018-12-14 23:53:26 PST

<rdar://problem/46751789>

Comment 5 Tim Horton 2020-03-25 22:35:48 PDT

Comment on attachment 357320 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357320&action=review

> Tools/Scripts/webkitpy/style/checkers/cpp.py:1107
> +    2. VERSION_MIN_REQUIRED never changes for a minor OS version.

This is not globally true, right? Only for macOS.

Comment 6 Alexey Proskuryakov 2020-03-26 09:24:32 PDT

I think that you are right. I don't know how deployment target is communicated to clang (is it -target or an invisible environment variable, and how does it interact with -mmacosx-version-min?), so I'm not confident enough to rewrite this comment.