Bug 192701 - [PSON] Stop exposing PolicyAction::Suspend to WebCore
Summary: [PSON] Stop exposing PolicyAction::Suspend to WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-14 09:12 PST by Chris Dumez
Modified: 2018-12-16 05:40 PST (History)
9 users (show)

See Also:


Attachments
Patch (45.00 KB, patch)
2018-12-14 09:30 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-12-14 09:12:15 PST
Stop exposing PolicyAction::Suspend to WebCore as this is a WebKit2-layer concept.
Comment 1 Chris Dumez 2018-12-14 09:30:58 PST
Created attachment 357319 [details]
Patch
Comment 2 Chris Dumez 2018-12-14 10:24:00 PST
Comment on attachment 357319 [details]
Patch

Clearing flags on attachment: 357319

Committed r239219: <https://trac.webkit.org/changeset/239219>
Comment 3 Chris Dumez 2018-12-14 10:24:02 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-12-14 10:25:29 PST
<rdar://problem/46734047>
Comment 5 Adrian Perez 2018-12-14 12:09:46 PST
(In reply to Chris Dumez from comment #2)
> Comment on attachment 357319 [details]
> Patch
> 
> Clearing flags on attachment: 357319
> 
> Committed r239219: <https://trac.webkit.org/changeset/239219>

This broke the build for both the GTK+ and WPE ports, I have
pushed a fix in https://trac.webkit.org/changeset/239225

Please *do* wait for all the EWS bots to run on your patches,
this would have been caught by them. I can spin a couple of
bots more for our ports if needed -- just let me know :)
Comment 6 Chris Dumez 2018-12-14 12:15:03 PST
(In reply to Adrian Perez from comment #5)
> (In reply to Chris Dumez from comment #2)
> > Comment on attachment 357319 [details]
> > Patch
> > 
> > Clearing flags on attachment: 357319
> > 
> > Committed r239219: <https://trac.webkit.org/changeset/239219>
> 
> This broke the build for both the GTK+ and WPE ports, I have
> pushed a fix in https://trac.webkit.org/changeset/239225
> 
> Please *do* wait for all the EWS bots to run on your patches,
> this would have been caught by them. I can spin a couple of
> bots more for our ports if needed -- just let me know :)

I apologize as I normally try to do that. However:
1. The GTK/WPE EWS was in a bad state and failing to build *without* my change
2. We still have rules in place (AFAIK) allow WK2 changes to break other ports.
Comment 7 Adrian Perez 2018-12-14 12:39:14 PST
(In reply to Chris Dumez from comment #6)
> (In reply to Adrian Perez from comment #5)
> > (In reply to Chris Dumez from comment #2)
> > > Comment on attachment 357319 [details]
> > > Patch
> > > 
> > > Clearing flags on attachment: 357319
> > > 
> > > Committed r239219: <https://trac.webkit.org/changeset/239219>
> > 
> > This broke the build for both the GTK+ and WPE ports, I have
> > pushed a fix in https://trac.webkit.org/changeset/239225
> > 
> > Please *do* wait for all the EWS bots to run on your patches,
> > this would have been caught by them. I can spin a couple of
> > bots more for our ports if needed -- just let me know :)
> 
> I apologize as I normally try to do that. However:
> 1. The GTK/WPE EWS was in a bad state and failing to build *without* my
> change
> 2. We still have rules in place (AFAIK) allow WK2 changes to break other
> ports.

No problem, it was just a gentle reminder. Thanks a lot for the
heads up about our EWS bots behaving funnily; if they did that
it's understandable that you went ahead and landed -- I will get
my stethoscope and see if there's something wrong with the bots :)
Comment 8 Chris Dumez 2018-12-14 12:51:23 PST
(In reply to Adrian Perez from comment #7)
> (In reply to Chris Dumez from comment #6)
> > (In reply to Adrian Perez from comment #5)
> > > (In reply to Chris Dumez from comment #2)
> > > > Comment on attachment 357319 [details]
> > > > Patch
> > > > 
> > > > Clearing flags on attachment: 357319
> > > > 
> > > > Committed r239219: <https://trac.webkit.org/changeset/239219>
> > > 
> > > This broke the build for both the GTK+ and WPE ports, I have
> > > pushed a fix in https://trac.webkit.org/changeset/239225
> > > 
> > > Please *do* wait for all the EWS bots to run on your patches,
> > > this would have been caught by them. I can spin a couple of
> > > bots more for our ports if needed -- just let me know :)
> > 
> > I apologize as I normally try to do that. However:
> > 1. The GTK/WPE EWS was in a bad state and failing to build *without* my
> > change
> > 2. We still have rules in place (AFAIK) allow WK2 changes to break other
> > ports.
> 
> No problem, it was just a gentle reminder. Thanks a lot for the
> heads up about our EWS bots behaving funnily; if they did that
> it's understandable that you went ahead and landed -- I will get
> my stethoscope and see if there's something wrong with the bots :)

If it helps, here is what the output looked like:
https://webkit-queues.webkit.org/results/10398265

No such file or directory at /home/ews/igalia-wpe-ews/WebKit/Tools/Scripts/webkitdirs.pm line 2338.
Comment 9 Adrian Perez 2018-12-16 05:40:53 PST
(In reply to Chris Dumez from comment #8)

> If it helps, here is what the output looked like:
> https://webkit-queues.webkit.org/results/10398265
> 
> No such file or directory at
> /home/ews/igalia-wpe-ews/WebKit/Tools/Scripts/webkitdirs.pm line 2338.

Thanks, I have been reanimating our EWS bots yesterday, and after
landing a couple of fixes and cleaning up the build directories
they seem to be working all fine except one to which I don't have
access right now. I'll get to it tomorrow when people show up online
at European office hours =)