Bug 192692 - [LFC][BFC] Introduce VerticalMargin and HorizontalMargin types.
Summary: [LFC][BFC] Introduce VerticalMargin and HorizontalMargin types.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-13 21:01 PST by zalan
Modified: 2018-12-14 07:23 PST (History)
5 users (show)

See Also:


Attachments
Patch (35.65 KB, patch)
2018-12-13 21:07 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (35.52 KB, patch)
2018-12-13 21:48 PST, zalan
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-12-13 21:01:23 PST
This is in preparation for adding more block collapsing functionality.
Comment 1 zalan 2018-12-13 21:07:39 PST
Created attachment 357297 [details]
Patch
Comment 2 zalan 2018-12-13 21:48:46 PST
Created attachment 357300 [details]
Patch
Comment 3 Antti Koivisto 2018-12-14 06:46:18 PST
Comment on attachment 357300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357300&action=review

> Source/WebCore/layout/FormattingContext.h:100
> +        static HorizontalMargin computedNonCollapsedHorizontalMarginValue(const LayoutState&, const Box&);
> +        static VerticalMargin::ComputedValues computedNonCollapsedVerticalMarginValue(const LayoutState&, const Box&);

Maybe HorizontalMargin can be ComputedHorizontalMargin?
Comment 4 zalan 2018-12-14 07:18:16 PST
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 357300 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=357300&action=review
> 
> > Source/WebCore/layout/FormattingContext.h:100
> > +        static HorizontalMargin computedNonCollapsedHorizontalMarginValue(const LayoutState&, const Box&);
> > +        static VerticalMargin::ComputedValues computedNonCollapsedVerticalMarginValue(const LayoutState&, const Box&);
> 
> Maybe HorizontalMargin can be ComputedHorizontalMargin?
Yeah, good idea. I've got a fixme on the non-computed horizontal margin value. Let me fix the together.
Comment 5 zalan 2018-12-14 07:22:09 PST
Committed r239205: <https://trac.webkit.org/changeset/239205>
Comment 6 Radar WebKit Bug Importer 2018-12-14 07:23:27 PST
<rdar://problem/46729951>