RESOLVED FIXED 192692
[LFC][BFC] Introduce VerticalMargin and HorizontalMargin types. 
https://bugs.webkit.org/show_bug.cgi?id=192692
Summary [LFC][BFC] Introduce VerticalMargin and HorizontalMargin types.
zalan
Reported 2018-12-13 21:01:23 PST
This is in preparation for adding more block collapsing functionality.
Attachments
Patch (35.65 KB, patch)
2018-12-13 21:07 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (35.52 KB, patch)
2018-12-13 21:48 PST, zalan 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2018-12-13 21:07:39 PST
Created attachment 357297 [details] Patch
zalan
Comment 2 2018-12-13 21:48:46 PST
Created attachment 357300 [details] Patch
Antti Koivisto
Comment 3 2018-12-14 06:46:18 PST
Comment on attachment 357300 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357300&action=review > Source/WebCore/layout/FormattingContext.h:100 > + static HorizontalMargin computedNonCollapsedHorizontalMarginValue(const LayoutState&, const Box&); > + static VerticalMargin::ComputedValues computedNonCollapsedVerticalMarginValue(const LayoutState&, const Box&); Maybe HorizontalMargin can be ComputedHorizontalMargin?
zalan
Comment 4 2018-12-14 07:18:16 PST
(In reply to Antti Koivisto from comment #3) > Comment on attachment 357300 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=357300&action=review > > > Source/WebCore/layout/FormattingContext.h:100 > > + static HorizontalMargin computedNonCollapsedHorizontalMarginValue(const LayoutState&, const Box&); > > + static VerticalMargin::ComputedValues computedNonCollapsedVerticalMarginValue(const LayoutState&, const Box&); > > Maybe HorizontalMargin can be ComputedHorizontalMargin? Yeah, good idea. I've got a fixme on the non-computed horizontal margin value. Let me fix the together.
zalan
Comment 5 2018-12-14 07:22:09 PST
Committed r239205: <https://trac.webkit.org/changeset/239205>
Radar WebKit Bug Importer
Comment 6 2018-12-14 07:23:27 PST
<rdar://problem/46729951>
Note You need to log in before you can comment on or make changes to this bug.