Bug 192691 - Web Inspector: Prefer "about:blank" instead of an empty string for WebPageDebuggable url
Summary: Web Inspector: Prefer "about:blank" instead of an empty string for WebPageDeb...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-13 20:03 PST by Joseph Pecoraro
Modified: 2018-12-14 11:37 PST (History)
6 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (1.49 KB, patch)
2018-12-13 20:05 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-12-13 20:03:41 PST
Prefer "about:blank" instead of an empty string for WebPageDebuggable url

When a WebPageProxy is created and has yet to actually load content it is better to display "about:blank" than an empty string.
Comment 1 Radar WebKit Bug Importer 2018-12-13 20:04:28 PST
<rdar://problem/46719798>
Comment 2 Joseph Pecoraro 2018-12-13 20:05:42 PST
Created attachment 357292 [details]
[PATCH] Proposed Fix
Comment 3 Darin Adler 2018-12-14 10:00:59 PST
Comment on attachment 357292 [details]
[PATCH] Proposed Fix

I suggest considering WTF::blankURL().string() rather than "about:blank"_s.
Comment 4 Brian Burg 2018-12-14 10:26:56 PST
LGTM. I don't think this is any worse for lack of localization.
Comment 5 WebKit Commit Bot 2018-12-14 10:26:57 PST
Comment on attachment 357292 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 357292

Committed r239221: <https://trac.webkit.org/changeset/239221>
Comment 6 WebKit Commit Bot 2018-12-14 10:26:58 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Joseph Pecoraro 2018-12-14 11:37:49 PST
Follow-up with the WTF::blankURL in:
<https://trac.webkit.org/r239224>