Bug 192689 - [iOS] Web Inspector: Occasional UIProcess crashes under WebPageProxy::showInspectorIndication
Summary: [iOS] Web Inspector: Occasional UIProcess crashes under WebPageProxy::showIns...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
Keywords: InRadar
Depends on:
Reported: 2018-12-13 19:35 PST by Joseph Pecoraro
Modified: 2018-12-13 20:39 PST (History)
6 users (show)

See Also:

[PATCH] Proposed Fix (1.96 KB, patch)
2018-12-13 19:36 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-12-13 19:35:19 PST
[iOS] Web Inspector: Occasional UIProcess crashes under WebPageProxy::showInspectorIndication

Steps to Reproduce:
1. Start Safari on iPad
2. Load a few tabs
3. Safari > Develop > iPad > hover items
  => Safari on iPad may crash

With some logging it looks like the WebPageProxy was not valid, it should have been removed from being a target:

    (WebKit) >>> WebPageDebuggable::setIndicating - yes
    (WebKit) >>> WebPageInspectorController::setIndicating - yes
    (WebKit) >>> WebPageProxy::showInspectorIndication - valid - no
    (WebKit) >>> WebPageProxy::showInspectorIndication - this - 0x10b87e618
    (WebKit) >>> WebPageProxy::showInspectorIndication - &pageClient() – 0x0
Comment 1 Joseph Pecoraro 2018-12-13 19:35:29 PST
Comment 2 Joseph Pecoraro 2018-12-13 19:36:45 PST
Created attachment 357288 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2018-12-13 20:10:09 PST
Comment on attachment 357288 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 357288

Committed r239196: <https://trac.webkit.org/changeset/239196>
Comment 4 WebKit Commit Bot 2018-12-13 20:10:10 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Chris Dumez 2018-12-13 20:39:25 PST
Committed r239197: <https://trac.webkit.org/changeset/239197>