RESOLVED FIXED 192686
Ensure that StructureFlags initialization always starts with Base::StructureFlags. 
https://bugs.webkit.org/show_bug.cgi?id=192686
Summary Ensure that StructureFlags initialization always starts with Base::StructureF...
Mark Lam
Reported 2018-12-13 16:43:16 PST
This is purely a refactoring effort to make the code consistently start all StructureFlags initialization with Base::StructureFlags. Previously, sometimes Base::StructureFlags is appended at the end, and sometimes, it is expressed using the name of the superclass. This patch makes the code all consistent and easier to do a quick eye scan audit on to verify that no StructureFlags are forgetting to inherit Base::StructureFlags.
Attachments
proposed patch. (47.06 KB, patch)
2018-12-13 16:49 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2018-12-13 16:49:52 PST
Created attachment 357271 [details] proposed patch.
Keith Miller
Comment 2 2018-12-13 17:48:05 PST
Comment on attachment 357271 [details] proposed patch. r=me.
Mark Lam
Comment 3 2018-12-13 17:48:46 PST
Comment on attachment 357271 [details] proposed patch. Thanks for the review. Landing now.
WebKit Commit Bot
Comment 4 2018-12-13 18:14:35 PST
Comment on attachment 357271 [details] proposed patch. Clearing flags on attachment: 357271 Committed r239191: <https://trac.webkit.org/changeset/239191>
WebKit Commit Bot
Comment 5 2018-12-13 18:14:37 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-12-13 18:15:37 PST
<rdar://problem/46717729>
Note You need to log in before you can comment on or make changes to this bug.