Bug 192686 - Ensure that StructureFlags initialization always starts with Base::StructureFlags.
Summary: Ensure that StructureFlags initialization always starts with Base::StructureF...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-13 16:43 PST by Mark Lam
Modified: 2018-12-13 18:15 PST (History)
11 users (show)

See Also:

Attachments
proposed patch. (47.06 KB, patch)
2018-12-13 16:49 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-12-13 16:43:16 PST 
This is purely a refactoring effort to make the code consistently start all StructureFlags initialization with Base::StructureFlags.  Previously, sometimes Base::StructureFlags is appended at the end, and sometimes, it is expressed using the name of the superclass.  This patch makes the code all consistent and easier to do a quick eye scan audit on to verify that no StructureFlags are forgetting to inherit Base::StructureFlags.
Comment 1 Mark Lam 2018-12-13 16:49:52 PST 
Created attachment 357271 [details]
proposed patch.
Comment 2 Keith Miller 2018-12-13 17:48:05 PST 
Comment on attachment 357271 [details]
proposed patch.

r=me.
Comment 3 Mark Lam 2018-12-13 17:48:46 PST 
Comment on attachment 357271 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 4 WebKit Commit Bot 2018-12-13 18:14:35 PST 
Comment on attachment 357271 [details]
proposed patch.

Clearing flags on attachment: 357271

Committed r239191: <https://trac.webkit.org/changeset/239191>
Comment 5 WebKit Commit Bot 2018-12-13 18:14:37 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-12-13 18:15:37 PST 
<rdar://problem/46717729>