The Inspector's Profiles panel should make how to record your first profile more obvious. Currently you're presented with a blank panel. You have to magically know to press the button in the status bar that contains a large gray dot. It would be much better if we had some text like "Record a profile using the Start Profiling button".
Created attachment 46447 [details] UI mock How about something like this?
This seems fine. I don't think we need to have a dot in the text button though. I would reduce the sillouette image a little too, maybe 10%.
Created attachment 46572 [details] Proposed patch How it looks like: - with single profile type: http://tinypic.com/r/izss4n/6 - with a couple of profile types: http://tinypic.com/r/2rpy802/6
Created attachment 46573 [details] Now using '--binary' for localizedStrings
Comment on attachment 46573 [details] Now using '--binary' for localizedStrings > +++ b/WebCore/inspector/front-end/ProfilesWelcomeView.js I think this should not be specific to Profiles panel, and should be generic for use by other Panels. > + registerProfileType: function(profileType) This can be generalized to take just an HTML message, then it isn't Profiles specific. > + } else { > + messageElement.innerHTML = message; > + } No braces here. > +.panel-enabler-view.profiles.welcome { > +.panel-enabler-view.profiles.welcome img { > +.panel-enabler-view.profiles.welcome .instructions { > +.panel-enabler-view.profiles.welcome .profile-type-message { > +.panel-enabler-view.welcome button { These selectors don't need .profiles in them. They can be generic to all welcome views. I think this is fine as, but I would like to see it be more generic.
Created attachment 46581 [details] generalized version not adding to commit-queue because it contains a binary diff made by git, which isn't supposed to be successfully applied by svn.
Comment on attachment 46581 [details] generalized version > + function messageButtonClicked() > + { > + profileType.buttonClicked.call(profileType); > + } This does not need to use .call(). You can also just use profileType.buttonClicked.bind(profileType) and pass it to addEventListener. Fix that and I'll r+.
Created attachment 46598 [details] comment addressed yes, that's simpler
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/WebCore.gypi M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/inspector/front-end/ProfileView.js M WebCore/inspector/front-end/ProfilesPanel.js M WebCore/inspector/front-end/WebKit.qrc A WebCore/inspector/front-end/WelcomeView.js M WebCore/inspector/front-end/inspector.css M WebCore/inspector/front-end/inspector.html Committed r53328