RESOLVED FIXED 192663
[BigInt] Add ValueBitRShift into DFG 
https://bugs.webkit.org/show_bug.cgi?id=192663
Summary [BigInt] Add ValueBitRShift into DFG
Caio Lima
Reported 2018-12-13 04:34:55 PST
...
Attachments
WIP - Patch (28.90 KB, patch)
2019-01-02 15:37 PST, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (28.02 KB, patch)
2019-01-19 07:06 PST, Caio Lima 		no flags
DetailsFormatted DiffDiff
Benchmarks (95.26 KB, text/plain)
2019-01-19 07:10 PST, Caio Lima 		no flags
Details
Patch (32.85 KB, patch)
2019-07-25 15:34 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (32.86 KB, patch)
2019-08-02 07:55 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (33.62 KB, patch)
2019-09-11 11:15 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (33.79 KB, patch)
2019-09-12 11:16 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Caio Lima
Comment 1 2019-01-02 15:37:08 PST
Created attachment 358218 [details] WIP - Patch
Caio Lima
Comment 2 2019-01-19 07:06:05 PST
Created attachment 359607 [details] Patch
Caio Lima
Comment 3 2019-01-19 07:10:01 PST
Created attachment 359608 [details] Benchmarks Changes seems perf neutral on macOS x86_64
Saam Barati
Comment 4 2019-01-20 14:46:17 PST
Comment on attachment 359607 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359607&action=review mostly LGTM, but you have a doesGC bug > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:400 > + case ValueBitRShift: you should abstract the code to still do constant folding. Just b/c we're UntypedUse should not mean we can't constant fold. It'd also be nice to add constant folding for BigInts, but perhaps that can be done in a followup patch, since it's not obvious what to do, since we'd want to allocate a JSCell > Source/JavaScriptCore/dfg/DFGDoesGC.cpp:103 > + case ValueBitRShift: should return true for BigIntUse
Caio Lima
Comment 5 2019-07-25 15:34:51 PDT
Created attachment 374914 [details] Patch
Caio Lima
Comment 6 2019-08-02 07:55:27 PDT
Created attachment 375408 [details] Patch
Caio Lima
Comment 7 2019-08-06 14:32:01 PDT
Ping review.
Caio Lima
Comment 8 2019-09-11 11:15:38 PDT
Created attachment 378570 [details] Patch
Caio Lima
Comment 9 2019-09-12 11:16:28 PDT
Created attachment 378660 [details] Patch
Caio Lima
Comment 10 2019-09-12 12:15:10 PDT
Ping review
Caio Lima
Comment 11 2019-09-20 13:37:35 PDT
Ping Review.
Robin Morisset
Comment 12 2019-09-24 06:36:25 PDT
Comment on attachment 378660 [details] Patch Sorry for having taken so long to review this patch. r=me
Caio Lima
Comment 13 2019-09-24 11:24:42 PDT
Comment on attachment 378660 [details] Patch Thank you very much for the review!
WebKit Commit Bot
Comment 14 2019-09-24 12:09:10 PDT
Comment on attachment 378660 [details] Patch Clearing flags on attachment: 378660 Committed r250313: <https://trac.webkit.org/changeset/250313>
WebKit Commit Bot
Comment 15 2019-09-24 12:09:12 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 16 2019-09-24 12:10:21 PDT
<rdar://problem/55671906>
Note You need to log in before you can comment on or make changes to this bug.